yiguolei commented on code in PR #45743:
URL: https://github.com/apache/doris/pull/45743#discussion_r1896442875


##########
be/src/vec/exec/scan/scanner_scheduler.cpp:
##########
@@ -254,6 +287,14 @@ void 
ScannerScheduler::_scanner_scan(std::shared_ptr<ScannerContext> ctx,
             }
 
             if (!eos && !scanner->is_open()) {
+                if (state->enable_reserve_memory()) {
+                    size_t block_avg_bytes = scanner->get_block_avg_bytes();
+                    auto st = 
thread_context()->try_reserve_memory(block_avg_bytes);
+                    if (!st.ok()) {
+                        handle_reserve_memory_failure(state, ctx, st, 
block_avg_bytes);

Review Comment:
   这里不能加这个,加了这个有可能会导致整个查询卡死。
   我们现在scanner的调度,需要保证至少scanner 扫描出一个block



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to