This is an automated email from the ASF dual-hosted git repository.
gavinchou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 7209101c248 [opt](log) Optimize compaction log to match output version
(#44375)
7209101c248 is described below
commit 7209101c2486b1a016b11676ef52ebe43ed5b5ea
Author: Gavin Chou <ga...@selectdb.com>
AuthorDate: Mon Dec 23 21:21:23 2024 +0800
[opt](log) Optimize compaction log to match output version (#44375)
---
be/src/cloud/cloud_base_compaction.cpp | 7 ++++---
be/src/cloud/cloud_cumulative_compaction.cpp | 8 +++++---
be/src/cloud/cloud_tablet.cpp | 3 +++
3 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/be/src/cloud/cloud_base_compaction.cpp
b/be/src/cloud/cloud_base_compaction.cpp
index 9742e57dcf9..d053214e964 100644
--- a/be/src/cloud/cloud_base_compaction.cpp
+++ b/be/src/cloud/cloud_base_compaction.cpp
@@ -268,8 +268,9 @@ Status CloudBaseCompaction::execute_compact() {
<< ", output_version=" << _output_version;
return res;
}
- LOG_INFO("finish CloudBaseCompaction, tablet_id={}, cost={}ms",
_tablet->tablet_id(),
- duration_cast<milliseconds>(steady_clock::now() - start).count())
+ LOG_INFO("finish CloudBaseCompaction, tablet_id={}, cost={}ms
range=[{}-{}]",
+ _tablet->tablet_id(),
duration_cast<milliseconds>(steady_clock::now() - start).count(),
+ _input_rowsets.front()->start_version(),
_input_rowsets.back()->end_version())
.tag("job_id", _uuid)
.tag("input_rowsets", _input_rowsets.size())
.tag("input_rows", _input_row_num)
@@ -343,7 +344,7 @@ Status CloudBaseCompaction::modify_rowsets() {
.tag("input_rowsets", _input_rowsets.size())
.tag("input_rows", _input_row_num)
.tag("input_segments", _input_segments)
- .tag("update_bitmap_size",
output_rowset_delete_bitmap->delete_bitmap.size());
+ .tag("num_output_delete_bitmap",
output_rowset_delete_bitmap->delete_bitmap.size());
compaction_job->set_delete_bitmap_lock_initiator(initiator);
}
diff --git a/be/src/cloud/cloud_cumulative_compaction.cpp
b/be/src/cloud/cloud_cumulative_compaction.cpp
index 1acf8efe32e..c7a82b322fb 100644
--- a/be/src/cloud/cloud_cumulative_compaction.cpp
+++ b/be/src/cloud/cloud_cumulative_compaction.cpp
@@ -204,8 +204,9 @@ Status CloudCumulativeCompaction::execute_compact() {
<< ", output_version=" << _output_version;
return res;
}
- LOG_INFO("finish CloudCumulativeCompaction, tablet_id={}, cost={}ms",
_tablet->tablet_id(),
- duration_cast<milliseconds>(steady_clock::now() - start).count())
+ LOG_INFO("finish CloudCumulativeCompaction, tablet_id={}, cost={}ms,
range=[{}-{}]",
+ _tablet->tablet_id(),
duration_cast<milliseconds>(steady_clock::now() - start).count(),
+ _input_rowsets.front()->start_version(),
_input_rowsets.back()->end_version())
.tag("job_id", _uuid)
.tag("input_rowsets", _input_rowsets.size())
.tag("input_rows", _input_row_num)
@@ -299,7 +300,8 @@ Status CloudCumulativeCompaction::modify_rowsets() {
.tag("input_rowsets", _input_rowsets.size())
.tag("input_rows", _input_row_num)
.tag("input_segments", _input_segments)
- .tag("update_bitmap_size",
output_rowset_delete_bitmap->delete_bitmap.size());
+ .tag("number_output_delete_bitmap",
+ output_rowset_delete_bitmap->delete_bitmap.size());
compaction_job->set_delete_bitmap_lock_initiator(initiator);
}
diff --git a/be/src/cloud/cloud_tablet.cpp b/be/src/cloud/cloud_tablet.cpp
index 4e351f7cfa5..31b7c6dd5dc 100644
--- a/be/src/cloud/cloud_tablet.cpp
+++ b/be/src/cloud/cloud_tablet.cpp
@@ -409,6 +409,9 @@ uint64_t CloudTablet::delete_expired_stale_rowsets() {
auto rs_it = _stale_rs_version_map.find(v_ts->version());
if (rs_it != _stale_rs_version_map.end()) {
expired_rowsets.push_back(rs_it->second);
+ LOG(INFO) << "erase stale rowset, tablet_id=" <<
tablet_id()
+ << " rowset_id=" <<
rs_it->second->rowset_id().to_string()
+ << " version=" << rs_it->first.to_string();
_stale_rs_version_map.erase(rs_it);
} else {
LOG(WARNING) << "cannot find stale rowset " <<
v_ts->version() << " in tablet "
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
