morrySnow commented on code in PR #40202:
URL: https://github.com/apache/doris/pull/40202#discussion_r1893751802
##########
be/src/http/http_channel.cpp:
##########
@@ -123,7 +123,8 @@ void HttpChannel::send_files(HttpRequest* request, const
std::string& root_dir,
VLOG_DEBUG << "http channel send file " << file_path << ", size: " <<
file_size;
evbuffer_add_printf(evb.get(), "File-Name: %s\r\n", file.c_str());
- evbuffer_add_printf(evb.get(), "Content-Length: %ld\r\n", file_size);
+ evbuffer_add_printf(evb.get(), "Content-Length: %" PRIi64 "\r\n",
file_size);
Review Comment:
maybe add some comment to explain the number format
##########
conf/be.conf:
##########
@@ -91,3 +91,4 @@ sys_log_level = INFO
aws_log_level=0
## If you are not running in aws cloud, you can disable EC2 metadata
AWS_EC2_METADATA_DISABLED=true
+enable_table_size_correctness_check=false
Review Comment:
see it in 2 pr, so should not do this change?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/InsertIntoValuesAnalyzer.java:
##########
@@ -0,0 +1,148 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands.insert;
+
+import org.apache.doris.common.Pair;
+import org.apache.doris.nereids.CascadesContext;
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.nereids.jobs.executor.AbstractBatchJobExecutor;
+import org.apache.doris.nereids.jobs.rewrite.RewriteJob;
+import org.apache.doris.nereids.rules.Rule;
+import org.apache.doris.nereids.rules.RuleType;
+import org.apache.doris.nereids.rules.analysis.BindSink;
+import org.apache.doris.nereids.rules.expression.ExpressionRewrite;
+import org.apache.doris.nereids.rules.expression.ExpressionRewriteRule;
+import org.apache.doris.nereids.rules.expression.rules.ConvertAggStateCast;
+import org.apache.doris.nereids.rules.expression.rules.FoldConstantRuleOnFE;
+import org.apache.doris.nereids.rules.rewrite.MergeProjects;
+import org.apache.doris.nereids.rules.rewrite.OneRewriteRuleFactory;
+import org.apache.doris.nereids.rules.rewrite.PushProjectIntoOneRowRelation;
+import org.apache.doris.nereids.rules.rewrite.PushProjectIntoUnion;
+import org.apache.doris.nereids.trees.expressions.NamedExpression;
+import org.apache.doris.nereids.trees.expressions.SlotReference;
+import org.apache.doris.nereids.trees.expressions.StatementScopeIdGenerator;
+import org.apache.doris.nereids.trees.plans.algebra.SetOperation.Qualifier;
+import org.apache.doris.nereids.trees.plans.logical.LogicalOneRowRelation;
+import org.apache.doris.nereids.trees.plans.logical.LogicalUnion;
+import org.apache.doris.nereids.types.DataType;
+
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.Lists;
+
+import java.util.List;
+
+/** InsertIntoValuesAnalyzer */
+public class InsertIntoValuesAnalyzer extends AbstractBatchJobExecutor {
+ public static final List<RewriteJob> INSERT_JOBS = jobs(
+ bottomUp(
+ new InlineTableToUnionOrOneRowRelation(),
+ new BindSink(),
+ new MergeProjects(),
+ // after bind olap table sink, the LogicalProject will be
generated under LogicalOlapTableSink,
+ // we should convert the agg state function in the
project, and evaluate some env parameters
+ // like encrypt key reference, for example: `values
(aes_encrypt("abc",key test.my_key))`,
+ // we should replace the `test.my_key` to real key
+ new
RewriteInsertIntoExpressions(ExpressionRewrite.bottomUp(
+ ConvertAggStateCast.INSTANCE,
+ FoldConstantRuleOnFE.PATTERN_MATCH_INSTANCE
+ ))
+ )
+ );
+
+ public static final List<RewriteJob> BATCH_INSERT_JOBS = jobs(
+ bottomUp(
+ new InlineTableToUnionOrOneRowRelation(),
+ new BindSink(),
+ new MergeProjects(),
+ new PushProjectIntoUnion(),
+ new PushProjectIntoOneRowRelation(),
Review Comment:
these rules is expensive? why inser jobs do not contain them?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/NereidsPlanner.java:
##########
@@ -605,6 +607,9 @@ private PhysicalPlan chooseBestPlan(Group rootGroup,
PhysicalProperties physical
}
private long getGarbageCollectionTime() {
+ if (!ConnectContext.get().getSessionVariable().enableProfile()) {
Review Comment:
👍🏻
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/InsertIntoTableCommand.java:
##########
@@ -215,7 +217,6 @@ public AbstractInsertExecutor initPlan(ConnectContext ctx,
StmtExecutor stmtExec
insertExecutor.getCoordinator().setTxnId(insertExecutor.getTxnId());
stmtExecutor.setCoord(insertExecutor.getCoordinator());
// for prepare and execute, avoiding normalization for every
execute command
- this.originalLogicalQuery = this.logicalQuery;
Review Comment:
remove this will lead prepare insert explain failed? if it could be removed,
remove the comment above it togather
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
