xinyiZzz commented on code in PR #9803:
URL: https://github.com/apache/incubator-doris/pull/9803#discussion_r886309105
##########
be/src/util/proto_util.h:
##########
@@ -74,4 +84,88 @@ inline void attachment_transfer_request_block(const Params*
brpc_request, brpc::
}
}
+// Embed tuple_data and brpc request serialization string in controller
attachment.
+template <typename Params, typename Closure>
+inline void request_embed_attachment_contain_tuple(Params* brpc_request,
+ const std::string&
tuple_data,
+ Closure* closure) {
+ auto row_batch = brpc_request->mutable_row_batch();
+ row_batch->set_tuple_data("");
+ request_embed_attachment(brpc_request, tuple_data, closure);
+}
+
+// Embed column_values and brpc request serialization string in controller
attachment.
+template <typename Params, typename Closure>
+inline void request_embed_attachment_contain_block(Params* brpc_request,
+ const std::string&
column_values,
+ Closure* closure) {
+ auto block = brpc_request->mutable_block();
+ block->set_column_values("");
+ request_embed_attachment(brpc_request, column_values, closure);
+}
+
+template <typename Params, typename Closure>
+inline void request_embed_attachment(Params* brpc_request, const std::string&
data,
+ Closure* closure) {
+ LOG(WARNING) << "http_brpc, request_embed_attachment start, data.size: "
<< data.size()
Review Comment:
Remove this LOG, this is for test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
