gavinchou commented on code in PR #45668:
URL: https://github.com/apache/doris/pull/45668#discussion_r1892674175
##########
be/src/cloud/cloud_meta_mgr.cpp:
##########
@@ -139,11 +139,75 @@ class MetaServiceProxy {
public:
static Status get_client(std::shared_ptr<MetaService_Stub>* stub) {
TEST_SYNC_POINT_RETURN_WITH_VALUE("MetaServiceProxy::get_client",
Status::OK(), stub);
- return get_pooled_client(stub);
+ return get_pooled_client(stub, nullptr);
+ }
+
+ static Status get_proxy(MetaServiceProxy** proxy) {
+ std::shared_ptr<MetaService_Stub> stub;
+ return get_pooled_client(&stub, proxy);
+ }
+
+ void set_unhealthy() {
+ std::unique_lock lock(_mutex);
+ maybe_unhealthy = true;
+ }
+
+ bool need_reconn(long now) {
+ return maybe_unhealthy &&
+ ((now - last_reconn_time_ms.front()) >
config::ms_rpc_reconn_interval_ms);
+ }
+
+ Status get(std::shared_ptr<MetaService_Stub>* stub) {
+ using namespace std::chrono;
+
+ auto now =
duration_cast<milliseconds>(system_clock::now().time_since_epoch()).count();
+ {
+ std::shared_lock lock(_mutex);
+ if (_deadline_ms >= now && !is_idle_timeout(now) &&
!need_reconn(now)) {
+ _last_access_at_ms.store(now, std::memory_order_relaxed);
+ *stub = _stub;
+ return Status::OK();
+ }
+ }
+
+ auto channel = std::make_unique<brpc::Channel>();
+ Status s = init_channel(channel.get());
+ if (!s.ok()) [[unlikely]] {
+ return s;
+ }
+
+ *stub = std::make_shared<MetaService_Stub>(channel.release(),
+
google::protobuf::Service::STUB_OWNS_CHANNEL);
+
+ long deadline = now;
+ // connection age only works without list endpoint.
+ if (!is_meta_service_endpoint_list &&
+ config::meta_service_connection_age_base_seconds > 0) {
+ std::default_random_engine rng(static_cast<uint32_t>(now));
+ std::uniform_int_distribution<> uni(
+ config::meta_service_connection_age_base_seconds,
+ config::meta_service_connection_age_base_seconds * 2);
+ deadline = now +
duration_cast<milliseconds>(seconds(uni(rng))).count();
+ } else {
+ deadline = LONG_MAX;
+ }
+
+ // Last one WIN
+ std::unique_lock lock(_mutex);
+ _last_access_at_ms.store(now, std::memory_order_relaxed);
+ _deadline_ms = deadline;
+ _stub = *stub;
+
+ last_reconn_time_ms.push(now);
+ last_reconn_time_ms.pop();
+ maybe_unhealthy = false;
+
+ return Status::OK();
}
private:
- static Status get_pooled_client(std::shared_ptr<MetaService_Stub>* stub) {
+ static Status get_pooled_client(std::shared_ptr<MetaService_Stub>* stub,
Review Comment:
add comment for this methods including behavior and params
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
