morningman commented on code in PR #41510:
URL: https://github.com/apache/doris/pull/41510#discussion_r1876585104
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/ExternalCatalog.java:
##########
@@ -781,6 +781,15 @@ protected ExternalDatabase<? extends ExternalTable>
buildDbForInit(String remote
return null;
}
}
+ } catch (RuntimeException e) {
+ // Handle "Found conflicting" exception explicitly
+ if (e.getMessage().contains("Found conflicting")) {
Review Comment:
better define "Found conflicting" as a static field.
and use it here and in RuntimeException msg
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/ExternalCatalog.java:
##########
@@ -781,6 +781,15 @@ protected ExternalDatabase<? extends ExternalTable>
buildDbForInit(String remote
return null;
}
}
+ } catch (RuntimeException e) {
+ // Handle "Found conflicting" exception explicitly
+ if (e.getMessage().contains("Found conflicting")) {
+ LOG.error(e.getMessage());
+ throw e; // Rethrow to let the caller handle this critical
issue
+ } else {
+ LOG.warn("Failed to check db {} exist in remote system,
ignore it.", localDbName, e);
Review Comment:
Why this can be ignored?
Add comment in code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
