github-actions[bot] commented on PR #45612:
URL: https://github.com/apache/doris/pull/45612#issuecomment-2553063885
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/12408964676";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In gensrc/script/gen_build_version.sh line 38:
if [[ ${build_version_hotfix} > 0 ]]; then
^-- SC2071 (error): > is for string
comparisons. Use -gt instead.
In gensrc/script/gen_build_version.sh line 228:
if [[ ${build_version_hotfix} > 0 ]]; then
^-- SC2071 (error): > is for string
comparisons. Use -gt instead.
In tools/ssb-tools/bin/create-ssb-tables.sh line 103:
echo "DB: ${DB}"
^---^ SC2154 (warning): DB is referenced but not assigned.
In tools/ssb-tools/bin/load-ssb-data.sh line 115:
mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" -e "$@"
^---^ SC2154
(warning): DB is referenced but not assigned.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 97:
local query_id=$(curl -s -X GET -u "${USER}:${PASSWORD}"
http://"${FE_HOST}":"${FE_HTTP_PORT}"/api/profile/lastqueryid)
^------^ SC2155 (warning): Declare and assign separately to avoid
masking return values.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 109:
IFS="|" read -r name queryid <<<"$entry"
^----^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
IFS="|" read -r name queryid <<<"${entry}"
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 111:
curl -s -X GET -u "${USER}:${PASSWORD}"
http://"${FE_HOST}":"${FE_HTTP_PORT}"/api/profile/text?query_id=${queryid}
>>"${PROFILE_DIR}/${profile_name}"
^--------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
curl -s -X GET -u "${USER}:${PASSWORD}"
http://"${FE_HOST}":"${FE_HTTP_PORT}"/api/profile/text?query_id="${queryid}";
>>"${PROFILE_DIR}/${profile_name}"
In tools/ssb-tools/bin/run-ssb-queries.sh line 97:
local query_id=$(curl -s -X GET -u "${USER}:${PASSWORD}"
http://"${FE_HOST}":"${FE_HTTP_PORT}"/api/profile/lastqueryid)
^------^ SC2155 (warning): Declare and assign separately to avoid
masking return values.
In tools/ssb-tools/bin/run-ssb-queries.sh line 109:
IFS="|" read -r name queryid <<<"$entry"
^----^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
IFS="|" read -r name queryid <<<"${entry}"
In tools/ssb-tools/bin/run-ssb-queries.sh line 111:
curl -s -X GET -u "${USER}:${PASSWORD}"
http://"${FE_HOST}":"${FE_HTTP_PORT}"/api/profile/text?query_id=${queryid}
>>"${PROFILE_DIR}/${profile_name}"
^--------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
curl -s -X GET -u "${USER}:${PASSWORD}"
http://"${FE_HOST}":"${FE_HTTP_PORT}"/api/profile/text?query_id="${queryid}";
>>"${PROFILE_DIR}/${profile_name}"
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 103:
echo "DB: ${DB}"
^---^ SC2154 (warning): DB is referenced but not assigned.
In tools/tpcds-tools/bin/load-tpcds-data.sh line 120:
echo "DB: ${DB}"
^---^ SC2154 (warning): DB is referenced but not assigned.
In tools/tpcds-tools/bin/run-tpcds-queries.sh line 118:
local query_id=$(curl -s -X GET -u "${USER}:${PASSWORD}"
http://"${FE_HOST}":"${FE_HTTP_PORT}"/api/profile/lastqueryid)
^------^ SC2155 (warning): Declare and assign separately to avoid
masking return values.
In tools/tpcds-tools/bin/run-tpcds-queries.sh line 130:
IFS="|" read -r name queryid <<<"$entry"
^----^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
IFS="|" read -r name queryid <<<"${entry}"
In tools/tpcds-tools/bin/run-tpcds-queries.sh line 132:
curl -s -X GET -u "${USER}:${PASSWORD}"
http://"${FE_HOST}":"${FE_HTTP_PORT}"/api/profile/text?query_id=${queryid}
>>"${PROFILE_DIR}/${profile_name}"
^--------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
curl -s -X GET -u "${USER}:${PASSWORD}"
http://"${FE_HOST}":"${FE_HTTP_PORT}"/api/profile/text?query_id="${queryid}";
>>"${PROFILE_DIR}/${profile_name}"
In tools/tpch-tools/bin/run-tpch-queries.sh line 115:
local query_id=$(curl -s -X GET -u "${USER}:${PASSWORD}"
http://"${FE_HOST}":"${FE_HTTP_PORT}"/api/profile/lastqueryid)
^------^ SC2155 (warning): Declare and assign separately to avoid
masking return values.
In tools/tpch-tools/bin/run-tpch-queries.sh line 127:
IFS="|" read -r name queryid <<<"$entry"
^----^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
IFS="|" read -r name queryid <<<"${entry}"
In tools/tpch-tools/bin/run-tpch-queries.sh line 129:
curl -s -X GET -u "${USER}:${PASSWORD}"
http://"${FE_HOST}":"${FE_HTTP_PORT}"/api/profile/text?query_id=${queryid}
>>"${PROFILE_DIR}/${profile_name}"
^--------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
curl -s -X GET -u "${USER}:${PASSWORD}"
http://"${FE_HOST}":"${FE_HTTP_PORT}"/api/profile/text?query_id="${queryid}";
>>"${PROFILE_DIR}/${profile_name}"
For more information:
https://www.shellcheck.net/wiki/SC2071 -- > is for string comparisons. Use
...
https://www.shellcheck.net/wiki/SC2154 -- DB is referenced but not
assigned.
https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to
...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- tools/ssb-tools/bin/run-ssb-flat-queries.sh.orig
+++ tools/ssb-tools/bin/run-ssb-flat-queries.sh
--- tools/tpcds-tools/bin/run-tpcds-queries.sh.orig
+++ tools/tpcds-tools/bin/run-tpcds-queries.sh
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
