github-actions[bot] commented on code in PR #45562: URL: https://github.com/apache/doris/pull/45562#discussion_r1890287122
########## be/src/vec/exec/format/parquet/parquet_column_chunk_file_reader.cpp: ########## @@ -0,0 +1,278 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vec/exec/format/parquet/parquet_column_chunk_file_reader.h" + +#include <cstring> +#include <stdexcept> + +namespace doris { +namespace vectorized { + +const Slice ParquetColumnChunkFileReader::EMPTY_SLICE; + +ParquetColumnChunkFileReader::ParquetColumnChunkFileReader( + std::vector<std::shared_ptr<ChunkReader>> chunks, ChunkReader::Statistics& statistics) + : chunks_(std::move(chunks)), + statistics_(statistics), + current_chunk_index_(-1), Review Comment: warning: member initializer for 'current_chunk_index_' is redundant [modernize-use-default-member-init] ```suggestion , ``` ########## be/src/vec/exec/format/parquet/parquet_column_chunk_file_reader.h: ########## @@ -0,0 +1,115 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <iterator> +#include <memory> +#include <vector> + +#include "common/status.h" +#include "io/fs/file_reader.h" +#include "io/fs/path.h" +#include "util/slice.h" +#include "vec/exec/format/parquet/reference_counted_reader.h" + +namespace doris { +namespace vectorized { Review Comment: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] ```suggestion namespace doris::vectorized { ``` be/src/vec/exec/format/parquet/parquet_column_chunk_file_reader.h:-1: ```diff - static const Slice EMPTY_SLICE; + static const Slice EMPTY_SLICE;} ``` ########## be/src/vec/exec/format/parquet/parquet_column_chunk_file_reader.cpp: ########## @@ -0,0 +1,278 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vec/exec/format/parquet/parquet_column_chunk_file_reader.h" + +#include <cstring> +#include <stdexcept> + +namespace doris { +namespace vectorized { + +const Slice ParquetColumnChunkFileReader::EMPTY_SLICE; + +ParquetColumnChunkFileReader::ParquetColumnChunkFileReader( + std::vector<std::shared_ptr<ChunkReader>> chunks, ChunkReader::Statistics& statistics) + : chunks_(std::move(chunks)), + statistics_(statistics), + current_chunk_index_(-1), + last_read_offset_(0) { + if (chunks_.empty()) { + throw std::invalid_argument("At least one chunk is expected but got none"); + } + current_slice_ = std::make_shared<Slice>(); +} + +ParquetColumnChunkFileReader::~ParquetColumnChunkFileReader() { + static_cast<void>(close()); +} + +ParquetColumnChunkFileReader::ParquetColumnChunkFileReader( + ParquetColumnChunkFileReader&& other) noexcept + : chunks_(std::move(other.chunks_)), + statistics_(other.statistics_), + current_chunk_index_(other.current_chunk_index_), + current_slice_(std::move(other.current_slice_)), + current_position_(other.current_position_), + last_read_offset_(other.last_read_offset_) { + other.current_slice_ = nullptr; + other.current_position_ = 0; + other.current_chunk_index_ = -1; + other.last_read_offset_ = 0; +} + +ParquetColumnChunkFileReader& ParquetColumnChunkFileReader::operator=( + ParquetColumnChunkFileReader&& other) noexcept { + if (this != &other) { + static_cast<void>(close()); + chunks_ = std::move(other.chunks_); + current_chunk_index_ = other.current_chunk_index_; + current_slice_ = std::move(other.current_slice_); + current_position_ = other.current_position_; + last_read_offset_ = other.last_read_offset_; + + other.current_slice_ = nullptr; + other.current_position_ = 0; + other.current_chunk_index_ = -1; + other.last_read_offset_ = 0; + } + return *this; +} + +Status ParquetColumnChunkFileReader::read_at_impl(size_t offset, Slice result, size_t* bytes_read, Review Comment: warning: function 'read_at_impl' exceeds recommended size/complexity thresholds [readability-function-size] ```cpp Status ParquetColumnChunkFileReader::read_at_impl(size_t offset, Slice result, size_t* bytes_read, ^ ``` <details> <summary>Additional context</summary> **be/src/vec/exec/format/parquet/parquet_column_chunk_file_reader.cpp:75:** 95 lines including whitespace and comments (threshold 80) ```cpp Status ParquetColumnChunkFileReader::read_at_impl(size_t offset, Slice result, size_t* bytes_read, ^ ``` </details> ########## be/src/vec/exec/format/parquet/parquet_column_chunk_file_reader.cpp: ########## @@ -0,0 +1,278 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vec/exec/format/parquet/parquet_column_chunk_file_reader.h" + +#include <cstring> +#include <stdexcept> + +namespace doris { +namespace vectorized { Review Comment: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] ```suggestion namespace doris::vectorized { ``` be/src/vec/exec/format/parquet/parquet_column_chunk_file_reader.cpp:-1: ```diff - >free(); + >free();} ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
