github-actions[bot] commented on code in PR #45604:
URL: https://github.com/apache/doris/pull/45604#discussion_r1890091372


##########
be/src/vec/columns/column_object.cpp:
##########
@@ -1141,13 +1141,13 @@ std::pair<Field, FieldInfo> 
ColumnObject::deserialize_from_sparse_column(const C
     const auto& data_ref = value->get_data_at(row);
     const char* data = data_ref.data;
     DCHECK(data_ref.size > 1);
-    const TypeIndex type = assert_cast<const 
TypeIndex>(*reinterpret_cast<const uint8_t*>(data++));
+    const TypeIndex type = static_cast<const 
TypeIndex>(*reinterpret_cast<const uint8_t*>(data++));

Review Comment:
   warning: use auto when initializing with a cast to avoid duplicating the 
type name [modernize-use-auto]
   
   ```suggestion
       const auto type = static_cast<const TypeIndex>(*reinterpret_cast<const 
uint8_t*>(data++));
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to