Mryange opened a new pull request, #45588:
URL: https://github.com/apache/doris/pull/45588
### What problem does this PR solve?
Previously, we allowed ColumnPtr to be directly converted to Column*:
```C++
ColumnPtr column;
const IColumn* ptr = column;
```
This can easily cause confusion.
For example, in the following code:
```C++
ColumnPtr column;
const auto& const_column = check_and_get_column<ColumnConst>(column);
```
The matched function is:
```C++
template <>
const doris::vectorized::ColumnConst*
check_and_get_column<doris::vectorized::ColumnConst>(
const IColumn* column)
```
However, the actual type of const_column is:
```C++
const doris::vectorized::ColumnConst* const&
```
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
