This is an automated email from the ASF dual-hosted git repository.
w41ter pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 3d1f0c67376 [fix](binlog) Avoid clear binlog dir (#45581)
3d1f0c67376 is described below
commit 3d1f0c67376c231e764ab214215106784fc0f2cb
Author: walter <maoch...@selectdb.com>
AuthorDate: Wed Dec 18 15:13:00 2024 +0800
[fix](binlog) Avoid clear binlog dir (#45581)
Related PR: #45445
The binlog dir is shared with all rowsets, so the existing binlog dir
should not be cleared directly.
Since the publish_txn might fail even if the add_to_binlog success, so
we need to check whether a file already exists before linking.
---
be/src/olap/rowset/beta_rowset.cpp | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/be/src/olap/rowset/beta_rowset.cpp
b/be/src/olap/rowset/beta_rowset.cpp
index 2546c87492d..a328b1b9e8b 100644
--- a/be/src/olap/rowset/beta_rowset.cpp
+++ b/be/src/olap/rowset/beta_rowset.cpp
@@ -18,6 +18,7 @@
#include "olap/rowset/beta_rowset.h"
#include <ctype.h>
+#include <errno.h>
#include <fmt/format.h>
#include <algorithm>
@@ -578,6 +579,10 @@ Status BetaRowset::add_to_binlog() {
}
}};
+ // The publish_txn might fail even if the add_to_binlog success, so we
need to check
+ // whether a file already exists before linking.
+ auto errno_is_file_exists = []() { return Errno::no() == EEXIST; };
+
// all segments are in the same directory, so cache binlog_dir without
multi times check
std::string binlog_dir;
for (int i = 0; i < segments_num; ++i) {
@@ -586,20 +591,18 @@ Status BetaRowset::add_to_binlog() {
if (binlog_dir.empty()) {
binlog_dir =
std::filesystem::path(seg_file).parent_path().append("_binlog").string();
- // Delete all existing files in binlog dir, to keep binlog dir
clean.
bool exists = true;
RETURN_IF_ERROR(fs->exists(binlog_dir, &exists));
- if (exists) {
- RETURN_IF_ERROR(fs->delete_directory(binlog_dir));
+ if (!exists) {
+ RETURN_IF_ERROR(fs->create_directory(binlog_dir));
}
- RETURN_IF_ERROR(fs->create_directory(binlog_dir));
}
auto binlog_file =
(std::filesystem::path(binlog_dir) /
std::filesystem::path(seg_file).filename())
.string();
VLOG_DEBUG << "link " << seg_file << " to " << binlog_file;
- if (!fs->link_file(seg_file, binlog_file).ok()) {
+ if (!fs->link_file(seg_file, binlog_file).ok() &&
!errno_is_file_exists()) {
status = Status::Error<OS_ERROR>("fail to create hard link.
from={}, to={}, errno={}",
seg_file, binlog_file,
Errno::no());
return status;
@@ -616,7 +619,7 @@ Status BetaRowset::add_to_binlog() {
std::filesystem::path(index_file).filename())
.string();
VLOG_DEBUG << "link " << index_file << " to " <<
binlog_index_file;
- if (!fs->link_file(index_file, binlog_index_file).ok()) {
+ if (!fs->link_file(index_file, binlog_index_file).ok() &&
!errno_is_file_exists()) {
status = Status::Error<OS_ERROR>(
"fail to create hard link. from={}, to={},
errno={}", index_file,
binlog_index_file, Errno::no());
@@ -632,7 +635,7 @@ Status BetaRowset::add_to_binlog() {
std::filesystem::path(index_file).filename())
.string();
VLOG_DEBUG << "link " << index_file << " to " <<
binlog_index_file;
- if (!fs->link_file(index_file, binlog_index_file).ok()) {
+ if (!fs->link_file(index_file, binlog_index_file).ok() &&
!errno_is_file_exists()) {
status = Status::Error<OS_ERROR>(
"fail to create hard link. from={}, to={},
errno={}", index_file,
binlog_index_file, Errno::no());
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
