github-actions[bot] commented on code in PR #45556:
URL: https://github.com/apache/doris/pull/45556#discussion_r1889640112
##########
be/src/olap/rowset/beta_rowset_reader.cpp:
##########
@@ -78,7 +78,6 @@ bool BetaRowsetReader::update_profile(RuntimeProfile*
profile) {
Status BetaRowsetReader::get_segment_iterators(RowsetReaderContext*
read_context,
Review Comment:
warning: function 'get_segment_iterators' has cognitive complexity of 55
(threshold 50) [readability-function-cognitive-complexity]
```cpp
Status BetaRowsetReader::get_segment_iterators(RowsetReaderContext*
read_context,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/beta_rowset_reader.cpp:90:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (_read_context->stats != nullptr) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:95:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(_rowset->load());
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:95:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_rowset->load());
^
```
**be/src/common/status.h:634:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:107:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (_read_context->lower_bound_keys != nullptr) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:108:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
for (int i = 0; i < _read_context->lower_bound_keys->size(); ++i) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:118:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (_read_context->delete_handler != nullptr) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:127:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
for (int i = 0; i < _read_context->return_columns->size(); ++i) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:139:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (_read_context->predicates != nullptr) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:155:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (_read_context->delete_bitmap != nullptr) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:170:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (_should_push_down_value_predicates()) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:171:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (_read_context->value_predicates != nullptr) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:201:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (_read_context->runtime_state != nullptr) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:213:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (_read_options.io_ctx.expiration_time <= UnixSeconds()) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:220:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (state != nullptr) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:222:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
?
state->query_options().enable_segment_cache
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:226:** +1
```cpp
bool should_use_cache = use_cache || (_read_context->reader_type ==
ReaderType::READER_QUERY &&
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:226:** +1
```cpp
bool should_use_cache = use_cache || (_read_context->reader_type ==
ReaderType::READER_QUERY &&
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:229:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(SegmentLoader::instance()->load_segments(_rowset,
&segment_cache_handle,
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:229:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(SegmentLoader::instance()->load_segments(_rowset,
&segment_cache_handle,
^
```
**be/src/common/status.h:634:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:236:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
for (size_t i = 0; i < segments.size(); i++) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:239:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (_read_context->record_rowids) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:242:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(get_segment_num_rows(&segment_num_rows));
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:242:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(get_segment_num_rows(&segment_num_rows));
^
```
**be/src/common/status.h:634:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:243:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_read_context->rowid_conversion->init_segment_map(rowset()->rowset_id(),
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:243:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_read_context->rowid_conversion->init_segment_map(rowset()->rowset_id(),
^
```
**be/src/common/status.h:634:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:248:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (seg_start == seg_end) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:255:** +1
```cpp
!is_merge_iterator && _read_context->reader_type ==
ReaderType::READER_QUERY;
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:256:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
for (int i = seg_start; i < seg_end; i++) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:261:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (use_lazy_init_iterators) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:266:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_segment_row_ranges.empty()) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:270:** +1, nesting level
increased to 3
```cpp
} else {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:277:** +1, nesting level
increased to 2
```cpp
} else {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:280:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_segment_row_ranges.empty()) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:283:** +1, nesting level
increased to 3
```cpp
} else {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:290:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (!status.ok()) {
^
```
**be/src/olap/rowset/beta_rowset_reader.cpp:297:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (iter->empty()) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
