morrySnow commented on code in PR #45233:
URL: https://github.com/apache/doris/pull/45233#discussion_r1889519257
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/StringArithmetic.java:
##########
@@ -208,63 +208,63 @@ public static Expression
ltrimVarcharVarchar(StringLikeLiteral first, StringLike
* Executable arithmetic functions rtrim
*/
@ExecFunction(name = "rtrim")
- public static Expression rtrimVarchar(StringLikeLiteral first) {
+ public static Expression rtrim(StringLikeLiteral first) {
return castStringLikeLiteral(first, trimImpl(first.getValue(), " ",
false, true));
}
/**
* Executable arithmetic functions rtrim
*/
@ExecFunction(name = "rtrim")
- public static Expression rtrimVarcharVarchar(StringLikeLiteral first,
StringLikeLiteral second) {
+ public static Expression rtrimVarchar(StringLikeLiteral first,
StringLikeLiteral second) {
Review Comment:
why remove signature in name? and give it a meaningless name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
