This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new 0f9a9ced76e branch-3.0: [Fix](ccr) Incorrectly generated sql with NONE
aggregate type #45452 (#45488)
0f9a9ced76e is described below
commit 0f9a9ced76e9395eeddc50d2ead6441c7fc4cca9
Author: github-actions[bot]
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Tue Dec 17 20:22:35 2024 +0800
branch-3.0: [Fix](ccr) Incorrectly generated sql with NONE aggregate type
#45452 (#45488)
Cherry-picked from #45452
Co-authored-by: Uniqueyou <wangyix...@selectdb.com>
---
fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java | 2 +-
.../src/test/java/org/apache/doris/analysis/ColumnDefTest.java | 8 ++++++++
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java
index 3604d6843f3..3a046f36a17 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java
@@ -662,7 +662,7 @@ public class ColumnDef {
sb.append("`").append(name).append("` ");
sb.append(typeDef.toSql()).append(" ");
- if (aggregateType != null) {
+ if (aggregateType != null && aggregateType != AggregateType.NONE) {
sb.append(aggregateType.name()).append(" ");
}
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/analysis/ColumnDefTest.java
b/fe/fe-core/src/test/java/org/apache/doris/analysis/ColumnDefTest.java
index c8764a0a2e0..0a8fcdf780b 100644
--- a/fe/fe-core/src/test/java/org/apache/doris/analysis/ColumnDefTest.java
+++ b/fe/fe-core/src/test/java/org/apache/doris/analysis/ColumnDefTest.java
@@ -38,6 +38,7 @@ public class ColumnDefTest {
private TypeDef stringCol;
private TypeDef floatCol;
private TypeDef booleanCol;
+ private TypeDef bitmapCol;
private ConnectContext ctx;
@Before
@@ -46,6 +47,7 @@ public class ColumnDefTest {
stringCol = new TypeDef(ScalarType.createChar(10));
floatCol = new TypeDef(ScalarType.createType(PrimitiveType.FLOAT));
booleanCol = new TypeDef(ScalarType.createType(PrimitiveType.BOOLEAN));
+ bitmapCol = new TypeDef(ScalarType.createType(PrimitiveType.BITMAP));
ctx = new ConnectContext();
new MockUp<ConnectContext>() {
@@ -80,6 +82,12 @@ public class ColumnDefTest {
Assert.assertEquals("10", column.getDefaultValue());
Assert.assertEquals(AggregateType.SUM, column.getAggregateType());
Assert.assertEquals("`col` float SUM NOT NULL DEFAULT \"10\" COMMENT
\"\"", column.toSql());
+
+ // agg none
+ column = new ColumnDef("col", bitmapCol, false, AggregateType.NONE,
false, DefaultValue.BITMAP_EMPTY_DEFAULT_VALUE, "");
+
+ Assert.assertEquals(AggregateType.NONE, column.getAggregateType());
+ Assert.assertEquals("`col` bitmap NOT NULL DEFAULT BITMAP_EMPTY
COMMENT \"\"", column.toSql());
}
@Test
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
