yujun777 opened a new pull request, #45543:
URL: https://github.com/apache/doris/pull/45543
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Two optimizations:
1. handle mix add / sub / multiply / divide
SimplifyArithmeticRule only handle add-sub, or multiply-divide, but not
both of them.
for example, if the expression root is add, then only simplify add-sub, but
not simplify multiply-divide.
for expr ` a + 10 + (b * 2 * 3) + 20`, it will opt as `a + (b * 2 * 3) +
30`, but after this pr it will opt as `a + (b * 6) + 30`
2. handle cast
SimplifyArithmeticRule not handle with cast.
for example, for expr `cast ( a * 2 * 30 as double) / (cast 10 as double)`
it will opt as `cast (a * 60 as double) / (cast 10 as double)`, but after this
pr it will opt as `cast (a as double) * 1.0`
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
