starocean999 commented on code in PR #45439:
URL: https://github.com/apache/doris/pull/45439#discussion_r1886030202
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -4529,6 +4532,42 @@ private Expression
getWildWhere(DorisParser.WildWhereContext ctx) {
}
}
+ @Override
+ public LogicalPlan visitShowColumnStats(ShowColumnStatsContext ctx) {
+ List<String> tableNameParts = visitMultipartIdentifier(ctx.tableName);
+ List<String> colNames = ctx.columnList == null ? ImmutableList.of() :
visitIdentifierList(ctx.columnList);
+ PartitionNames partitionNames =
parsePartitionSpec(ctx.partitionSpec());
+ boolean isCached = ctx.CACHED() != null;
+
+ return new ShowColumnStatsCommand(new TableNameInfo(tableNameParts),
colNames, partitionNames, isCached);
+ }
+
+ private PartitionNames parsePartitionSpec(PartitionSpecContext ctx) {
Review Comment:
there is a visitPartitionSpec method already, please use it instead of
creating a new one. Take bellow as example:
```
Pair<Boolean, List<String>> partitionSpec =
visitPartitionSpec(ctx.partitions);
PartitionNamesInfo partitionNames = new
PartitionNamesInfo(partitionSpec.first, partitionSpec.second);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
