zclllyybb commented on code in PR #45159:
URL: https://github.com/apache/doris/pull/45159#discussion_r1884180249
##########
be/src/vec/functions/function_date_or_datetime_computation.cpp:
##########
@@ -21,24 +21,53 @@
namespace doris::vectorized {
-using FunctionAddSeconds =
FunctionDateOrDateTimeComputation<AddSecondsImpl<DataTypeDateTime>>;
-using FunctionAddMinutes =
FunctionDateOrDateTimeComputation<AddMinutesImpl<DataTypeDateTime>>;
-using FunctionAddHours =
FunctionDateOrDateTimeComputation<AddHoursImpl<DataTypeDateTime>>;
-using FunctionAddDays =
FunctionDateOrDateTimeComputation<AddDaysImpl<DataTypeDateTime>>;
-using FunctionAddWeeks =
FunctionDateOrDateTimeComputation<AddWeeksImpl<DataTypeDateTime>>;
-using FunctionAddMonths =
FunctionDateOrDateTimeComputation<AddMonthsImpl<DataTypeDateTime>>;
-using FunctionAddQuarters =
FunctionDateOrDateTimeComputation<AddQuartersImpl<DataTypeDateTime>>;
-using FunctionAddYears =
FunctionDateOrDateTimeComputation<AddYearsImpl<DataTypeDateTime>>;
-
-using FunctionSubSeconds =
FunctionDateOrDateTimeComputation<SubtractSecondsImpl<DataTypeDateTime>>;
-using FunctionSubMinutes =
FunctionDateOrDateTimeComputation<SubtractMinutesImpl<DataTypeDateTime>>;
-using FunctionSubHours =
FunctionDateOrDateTimeComputation<SubtractHoursImpl<DataTypeDateTime>>;
-using FunctionSubDays =
FunctionDateOrDateTimeComputation<SubtractDaysImpl<DataTypeDateTime>>;
-using FunctionSubWeeks =
FunctionDateOrDateTimeComputation<SubtractWeeksImpl<DataTypeDateTime>>;
-using FunctionSubMonths =
FunctionDateOrDateTimeComputation<SubtractMonthsImpl<DataTypeDateTime>>;
-using FunctionSubQuarters =
+using FunctionDatetimeAddSeconds =
+ FunctionDateOrDateTimeComputation<AddSecondsImpl<DataTypeDateTime>>;
+using FunctionDatetimeAddMinutes =
+ FunctionDateOrDateTimeComputation<AddMinutesImpl<DataTypeDateTime>>;
+using FunctionDatetimeAddHours =
FunctionDateOrDateTimeComputation<AddHoursImpl<DataTypeDateTime>>;
+using FunctionDatetimeAddDays =
FunctionDateOrDateTimeComputation<AddDaysImpl<DataTypeDateTime>>;
+using FunctionDatetimeAddWeeks =
FunctionDateOrDateTimeComputation<AddWeeksImpl<DataTypeDateTime>>;
+using FunctionDatetimeAddMonths =
+ FunctionDateOrDateTimeComputation<AddMonthsImpl<DataTypeDateTime>>;
+using FunctionDatetimeAddQuarters =
+ FunctionDateOrDateTimeComputation<AddQuartersImpl<DataTypeDateTime>>;
+using FunctionDatetimeAddYears =
FunctionDateOrDateTimeComputation<AddYearsImpl<DataTypeDateTime>>;
+
+using FunctionAddSeconds =
FunctionDateOrDateTimeComputation<AddSecondsImpl<DataTypeDate>>;
Review Comment:
also add type for these
##########
be/src/vec/functions/function_date_or_datetime_computation.h:
##########
@@ -89,7 +89,15 @@ extern ResultType date_time_add(const Arg& t, Int64 delta,
bool& is_null) {
template <typename DateType>
\
struct CLASS {
\
using ReturnType = std::conditional_t<
\
- date_cast::IsV1<DateType>(), DataTypeDateTime,
\
+ date_cast::IsV1<DateType>(),
\
Review Comment:
make sure this pr's content has relative information
##########
be/src/vec/functions/array/function_array_apply.cpp:
##########
@@ -64,6 +64,8 @@ class FunctionArrayApply : public IFunction {
size_t get_number_of_arguments() const override { return 3; }
ColumnNumbers get_arguments_that_are_always_constant() const override {
return {1, 2}; }
+ bool dont_append_return_type_name_when_register_function() const override
{ return true; }
Review Comment:
use `has_return_type_in_signature` as name and use the opposite in values
and usages
##########
be/src/vec/functions/simple_function_factory.h:
##########
@@ -183,17 +196,19 @@ class SimpleFunctionFactory {
: arg.type->get_family_name());
}
}
+ key_str.append(remove_nullable(return_type)->get_family_name());
auto iter = function_creators.find(key_str);
Review Comment:
add comment here, why the return type check is active here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
