github-actions[bot] commented on code in PR #45414: URL: https://github.com/apache/doris/pull/45414#discussion_r1883809470
########## be/src/vec/exprs/vcompound_pred.h: ########## @@ -231,6 +243,32 @@ class VCompoundPred : public VectorizedFnCall { return null_map_data; }; + auto vector_vector = [&]<bool is_and_op>() { + if (lhs_mem_can_reuse) { + *result_column_id = lhs_id; + } else if (rhs_mem_can_reuse) { + *result_column_id = rhs_id; + + auto tmp_column = rhs_data_column; Review Comment: warning: 'auto tmp_column' can be declared as 'auto *tmp_column' [readability-qualified-auto] ```suggestion auto *tmp_column = rhs_data_column; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org