BiteTheDDDDt commented on code in PR #45207:
URL: https://github.com/apache/doris/pull/45207#discussion_r1883606855


##########
be/src/pipeline/exec/exchange_sink_operator.cpp:
##########
@@ -186,9 +186,6 @@ void 
ExchangeSinkLocalState::on_channel_finished(InstanceLoId channel_id) {
         _finished_channels.emplace(channel_id);
         if (_working_channels_count.fetch_sub(1) == 1) {
             set_reach_limit();
-            if (_finish_dependency) {

Review Comment:
   set_reach_limit 实际上会使pipeline 
task触发is_finished的逻辑,这个pr中触发is_finished会直接set_wake_up_early,以统一的方式来set 
dependency



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to