amosbird opened a new pull request, #9824: URL: https://github.com/apache/incubator-doris/pull/9824
## Problem Summary: Fix some memory leak issues in vectorized engine. ## Checklist(Required) 1. Does it affect the original behavior: (No) 2. Has unit tests been added: (No Need) 3. Has document been added or modified: (No Need) 4. Does it need to update dependencies: (No) 5. Are there any changes that cannot be rolled back: (No) ## Further comments The following leak issues are catched by running stress tests with tpch queries. 1. When building runtime filters, `VRuntimeFilterSlots` is not deleted. 2. `HashJoinNode` doesn't close owned expression contexts. 3. `VExprContext` doesn't free owned function contexts. 4. `AggregationNode` doesn't close owned aggregate_evaluators. Also it might fail to close properly. 5. merging `VExchangeNode` doesn't close owned vsort_exec_exprs. 6. `VSortNode` doesn't return error code if close fails. There is also a related fix proposed in https://github.com/apache/incubator-doris/pull/9820 whose implementation differs from `ExprContext`. I think deallocation suits better inside d'tor, which is more consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
