gavinchou commented on code in PR #45360:
URL: https://github.com/apache/doris/pull/45360#discussion_r1881749582
##########
be/src/io/fs/err_utils.cpp:
##########
@@ -122,13 +122,13 @@ Status s3fs_error(const Aws::S3::S3Error& err,
std::string_view msg) {
using namespace Aws::Http;
switch (err.GetResponseCode()) {
case HttpResponseCode::NOT_FOUND:
- return Status::Error<NOT_FOUND, false>("{}: {} {} type={},
request_id={}", msg,
- err.GetExceptionName(),
err.GetMessage(),
+ return Status::Error<NOT_FOUND, false>("{}: {} {} code={NOT_FOUND}
type={}, request_id={}",
Review Comment:
why not just use "code=NOT_FOUND" instead of "code={NOT_FOUND}"
##########
be/src/io/fs/err_utils.cpp:
##########
@@ -122,13 +122,13 @@ Status s3fs_error(const Aws::S3::S3Error& err,
std::string_view msg) {
using namespace Aws::Http;
switch (err.GetResponseCode()) {
case HttpResponseCode::NOT_FOUND:
- return Status::Error<NOT_FOUND, false>("{}: {} {} type={},
request_id={}", msg,
- err.GetExceptionName(),
err.GetMessage(),
+ return Status::Error<NOT_FOUND, false>("{}: {} {} code={NOT_FOUND}
type={}, request_id={}",
+ msg, err.GetExceptionName(),
err.GetMessage(),
err.GetErrorType(),
err.GetRequestId());
case HttpResponseCode::FORBIDDEN:
- return Status::Error<PERMISSION_DENIED, false>("{}: {} {} type={},
request_id={}", msg,
- err.GetExceptionName(),
err.GetMessage(),
- err.GetErrorType(),
err.GetRequestId());
+ return Status::Error<PERMISSION_DENIED, false>(
+ "{}: {} {} code={FORBIDDEN} type={}, request_id={}", msg,
err.GetExceptionName(),
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
