zhannngchen commented on code in PR #45287:
URL: https://github.com/apache/doris/pull/45287#discussion_r1881482951
##########
be/src/olap/base_tablet.h:
##########
@@ -146,7 +146,8 @@ class BaseTablet {
RowsetSharedPtr rowset, const TupleDescriptor* desc,
OlapReaderStatistics& stats, std::string& values,
bool write_to_cache = false);
-
+ bool key_is_not_in_segment(Slice key, const KeyBoundsPB&
segment_key_bounds,
Review Comment:
the method name feels a bit unnatural; it should be called
`is_key_in_segment`.
And it's better as a util method, not a member method of `BaseTablet`
##########
be/src/util/slice.cpp:
##########
@@ -27,4 +27,23 @@ Slice::Slice(const faststring& s)
data((char*)(s.data())),
size(s.size()) {}
+bool Slice::origin_is_strictly_less_than(Slice X, bool X_is_truncated, Slice Y,
+ bool Y_is_truncated) {
Review Comment:
`Y_is_truncated` is useless?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
