github-actions[bot] commented on code in PR #45334:
URL: https://github.com/apache/doris/pull/45334#discussion_r1881352557
##########
be/src/vec/exprs/vcompound_pred.h:
##########
@@ -57,7 +57,8 @@ class VCompoundPred : public VectorizedFnCall {
const std::string& expr_name() const override { return _expr_name; }
- Status evaluate_inverted_index(VExprContext* context, uint32_t
segment_num_rows) override {
+ Status evaluate_inverted_index(VExprContext* context,
Review Comment:
warning: function 'evaluate_inverted_index' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status evaluate_inverted_index(VExprContext* context,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/exprs/vcompound_pred.h:59:** 95 lines including whitespace and
comments (threshold 80)
```cpp
Status evaluate_inverted_index(VExprContext* context,
^
```
</details>
##########
be/src/vec/exprs/vcompound_pred.h:
##########
@@ -148,14 +149,14 @@
if (all_pass && !res.is_empty()) {
// set fast_execute when expr evaluated by inverted index correctly
- _can_fast_execute = true;
+ context->can_fast_execute = true;
context->get_inverted_index_context()->set_inverted_index_result_for_expr(this,
res);
}
return Status::OK();
}
- Status execute(VExprContext* context, Block* block, int* result_column_id)
override {
- if (_can_fast_execute && fast_execute(context, block,
result_column_id)) {
+ Status execute(VExprContext* context, Block* block, int* result_column_id)
const override {
Review Comment:
warning: function 'execute' has cognitive complexity of 113 (threshold 50)
[readability-function-cognitive-complexity]
```cpp
Status execute(VExprContext* context, Block* block, int*
result_column_id) const override {
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/exprs/vcompound_pred.h:158:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (context->can_fast_execute && fast_execute(context, block,
result_column_id)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:158:** +1
```cpp
if (context->can_fast_execute && fast_execute(context, block,
result_column_id)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:161:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (get_num_children() == 1 ||
!_all_child_is_compound_and_not_const()) {
^
```
**be/src/vec/exprs/vcompound_pred.h:161:** +1
```cpp
if (get_num_children() == 1 ||
!_all_child_is_compound_and_not_const()) {
^
```
**be/src/vec/exprs/vcompound_pred.h:167:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(_children[0]->execute(context, block, &lhs_id));
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exprs/vcompound_pred.h:167:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_children[0]->execute(context, block, &lhs_id));
^
```
**be/src/common/status.h:634:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exprs/vcompound_pred.h:179:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (lhs_is_nullable) {
^
```
**be/src/vec/exprs/vcompound_pred.h:193:** nesting level increased to 1
```cpp
auto get_rhs_colum = [&]() {
^
```
**be/src/vec/exprs/vcompound_pred.h:194:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (rhs_id == -1) {
^
```
**be/src/vec/exprs/vcompound_pred.h:195:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_children[1]->execute(context, block,
&rhs_id));
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exprs/vcompound_pred.h:195:** +4, including nesting penalty of
3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_children[1]->execute(context, block,
&rhs_id));
^
```
**be/src/common/status.h:634:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exprs/vcompound_pred.h:205:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
if (rhs_is_nullable) {
^
```
**be/src/vec/exprs/vcompound_pred.h:213:** nesting level increased to 1
```cpp
auto return_result_column_id = [&](ColumnPtr res_column, int res_id)
-> int {
^
```
**be/src/vec/exprs/vcompound_pred.h:214:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (result_is_nullable && !res_column->is_nullable()) {
^
```
**be/src/vec/exprs/vcompound_pred.h:214:** +1
```cpp
if (result_is_nullable && !res_column->is_nullable()) {
^
```
**be/src/vec/exprs/vcompound_pred.h:223:** nesting level increased to 1
```cpp
auto create_null_map_column = [&](ColumnPtr& null_map_column,
^
```
**be/src/vec/exprs/vcompound_pred.h:225:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (null_map_data == nullptr) {
^
```
**be/src/vec/exprs/vcompound_pred.h:234:** nesting level increased to 1
```cpp
auto vector_vector_null = [&]<bool is_and_op>() {
^
```
**be/src/vec/exprs/vcompound_pred.h:244:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if constexpr (is_and_op) {
^
```
**be/src/vec/exprs/vcompound_pred.h:245:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
for (size_t i = 0; i < size; ++i) {
^
```
**be/src/vec/exprs/vcompound_pred.h:250:** +1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/exprs/vcompound_pred.h:251:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
for (size_t i = 0; i < size; ++i) {
^
```
**be/src/vec/exprs/vcompound_pred.h:264:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (_op == TExprOpcode::COMPOUND_AND) {
^
```
**be/src/vec/exprs/vcompound_pred.h:267:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if ((lhs_all_false && !lhs_is_nullable) || (lhs_all_false &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:267:** +1
```cpp
if ((lhs_all_false && !lhs_is_nullable) || (lhs_all_false &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:267:** +1
```cpp
if ((lhs_all_false && !lhs_is_nullable) || (lhs_all_false &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:267:** +1
```cpp
if ((lhs_all_false && !lhs_is_nullable) || (lhs_all_false &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:270:** +1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/exprs/vcompound_pred.h:271:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(get_rhs_colum());
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exprs/vcompound_pred.h:271:** +4, including nesting penalty of
3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(get_rhs_colum());
^
```
**be/src/common/status.h:634:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exprs/vcompound_pred.h:273:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
if ((lhs_all_true && !lhs_is_nullable) || //not null
column
^
```
**be/src/vec/exprs/vcompound_pred.h:273:** +1
```cpp
if ((lhs_all_true && !lhs_is_nullable) || //not null
column
^
```
**be/src/vec/exprs/vcompound_pred.h:273:** +1
```cpp
if ((lhs_all_true && !lhs_is_nullable) || //not null
column
^
```
**be/src/vec/exprs/vcompound_pred.h:274:** +1
```cpp
(lhs_all_true && lhs_all_is_not_null)) { //nullable
column
^
```
**be/src/vec/exprs/vcompound_pred.h:277:** +1, nesting level increased to 3
```cpp
} else if ((rhs_all_false && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:277:** +1
```cpp
} else if ((rhs_all_false && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:277:** +1
```cpp
} else if ((rhs_all_false && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:278:** +1
```cpp
(rhs_all_false && rhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:281:** +1, nesting level increased to 3
```cpp
} else if ((rhs_all_true && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:281:** +1
```cpp
} else if ((rhs_all_true && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:281:** +1
```cpp
} else if ((rhs_all_true && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:282:** +1
```cpp
(rhs_all_true && rhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:285:** +1, nesting level increased to 3
```cpp
} else {
^
```
**be/src/vec/exprs/vcompound_pred.h:286:** +4, including nesting penalty of
3, nesting level increased to 4
```cpp
if (!result_is_nullable) {
^
```
**be/src/vec/exprs/vcompound_pred.h:288:** +5, including nesting penalty of
4, nesting level increased to 5
```cpp
for (size_t i = 0; i < size; i++) {
^
```
**be/src/vec/exprs/vcompound_pred.h:291:** +1, nesting level increased to 4
```cpp
} else {
^
```
**be/src/vec/exprs/vcompound_pred.h:296:** +1, nesting level increased to 1
```cpp
} else if (_op == TExprOpcode::COMPOUND_OR) {
^
```
**be/src/vec/exprs/vcompound_pred.h:299:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if ((lhs_all_true && !lhs_is_nullable) || (lhs_all_true &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:299:** +1
```cpp
if ((lhs_all_true && !lhs_is_nullable) || (lhs_all_true &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:299:** +1
```cpp
if ((lhs_all_true && !lhs_is_nullable) || (lhs_all_true &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:299:** +1
```cpp
if ((lhs_all_true && !lhs_is_nullable) || (lhs_all_true &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:302:** +1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/exprs/vcompound_pred.h:303:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(get_rhs_colum());
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exprs/vcompound_pred.h:303:** +4, including nesting penalty of
3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(get_rhs_colum());
^
```
**be/src/common/status.h:634:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exprs/vcompound_pred.h:304:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
if ((lhs_all_false && !lhs_is_nullable) || (lhs_all_false &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:304:** +1
```cpp
if ((lhs_all_false && !lhs_is_nullable) || (lhs_all_false &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:304:** +1
```cpp
if ((lhs_all_false && !lhs_is_nullable) || (lhs_all_false &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:304:** +1
```cpp
if ((lhs_all_false && !lhs_is_nullable) || (lhs_all_false &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:307:** +1, nesting level increased to 3
```cpp
} else if ((rhs_all_true && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:307:** +1
```cpp
} else if ((rhs_all_true && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:307:** +1
```cpp
} else if ((rhs_all_true && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:308:** +1
```cpp
(rhs_all_true && rhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:311:** +1, nesting level increased to 3
```cpp
} else if ((rhs_all_false && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:311:** +1
```cpp
} else if ((rhs_all_false && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:311:** +1
```cpp
} else if ((rhs_all_false && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:312:** +1
```cpp
(rhs_all_false && rhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:315:** +1, nesting level increased to 3
```cpp
} else {
^
```
**be/src/vec/exprs/vcompound_pred.h:316:** +4, including nesting penalty of
3, nesting level increased to 4
```cpp
if (!result_is_nullable) {
^
```
**be/src/vec/exprs/vcompound_pred.h:318:** +5, including nesting penalty of
4, nesting level increased to 5
```cpp
for (size_t i = 0; i < size; i++) {
^
```
**be/src/vec/exprs/vcompound_pred.h:321:** +1, nesting level increased to 4
```cpp
} else {
^
```
**be/src/vec/exprs/vcompound_pred.h:326:** +1, nesting level increased to 1
```cpp
} else {
^
```
</details>
##########
be/src/vec/exprs/vcompound_pred.h:
##########
@@ -148,14 +149,14 @@
if (all_pass && !res.is_empty()) {
// set fast_execute when expr evaluated by inverted index correctly
- _can_fast_execute = true;
+ context->can_fast_execute = true;
context->get_inverted_index_context()->set_inverted_index_result_for_expr(this,
res);
}
return Status::OK();
}
- Status execute(VExprContext* context, Block* block, int* result_column_id)
override {
- if (_can_fast_execute && fast_execute(context, block,
result_column_id)) {
+ Status execute(VExprContext* context, Block* block, int* result_column_id)
const override {
Review Comment:
warning: function 'execute' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
Status execute(VExprContext* context, Block* block, int*
result_column_id) const override {
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/exprs/vcompound_pred.h:157:** 174 lines including whitespace
and comments (threshold 80)
```cpp
Status execute(VExprContext* context, Block* block, int*
result_column_id) const override {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
