wyxxxcat commented on code in PR #44997:
URL: https://github.com/apache/doris/pull/44997#discussion_r1881345082
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java:
##########
@@ -680,7 +670,22 @@ public String toSql() {
}
if (defaultValue.isSet) {
- sb.append(defaultValue.toSql()).append(" ");
+ sb.append("DEFAULT ");
+ if (defaultValue.value != null) {
+ if (typeDef.getType().getPrimitiveType() !=
PrimitiveType.BITMAP
+ && typeDef.getType().getPrimitiveType() !=
PrimitiveType.HLL) {
+ if (defaultValue.defaultValueExprDef != null) {
+ sb.append(defaultValue.value);
+ } else {
+
sb.append("\"").append(SqlUtils.escapeQuota(defaultValue.value)).append("\"");
+ }
+ } else if (typeDef.getType().getPrimitiveType() ==
PrimitiveType.BITMAP) {
Review Comment:
when analyze, it will return error
```
if (type.getPrimitiveType() == PrimitiveType.HLL) {
if (defaultValue.isSet) {
throw new AnalysisException("Hll type column can not set
default value");
}
defaultValue = DefaultValue.HLL_EMPTY_DEFAULT_VALUE;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
