morrySnow commented on code in PR #45081:
URL: https://github.com/apache/doris/pull/45081#discussion_r1877565817
##########
fe/fe-core/src/test/java/org/apache/doris/nereids/rules/expression/SimplifyRangeTest.java:
##########
Review Comment:
rename to RangeInferenceTest
##########
fe/fe-core/src/test/java/org/apache/doris/nereids/rules/expression/SimplifyRangeTest.java:
##########
@@ -62,7 +66,7 @@ public SimplifyRangeTest() {
@Test
public void testSimplify() {
executor = new ExpressionRuleExecutor(ImmutableList.of(
- bottomUp(SimplifyRange.INSTANCE)
+ bottomUp(SimplifyRange.INSTANCE, OrAddMinMax.INSTANCE)
Review Comment:
should we test them separately?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/MutableState.java:
##########
@@ -31,6 +31,8 @@ public interface MutableState {
String KEY_OR_TO_IN = "or_to_in";
+ String KEY_SIMPLIFY_RANGE = "simplify_range";
Review Comment:
range inference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
