github-actions[bot] commented on code in PR #44469:
URL: https://github.com/apache/doris/pull/44469#discussion_r1877538227
##########
be/src/pipeline/exec/hashjoin_build_sink.cpp:
##########
@@ -108,6 +113,93 @@ Status HashJoinBuildSinkLocalState::open(RuntimeState*
state) {
return Status::OK();
}
+size_t HashJoinBuildSinkLocalState::get_reserve_mem_size(RuntimeState* state,
bool eos) {
Review Comment:
warning: function 'get_reserve_mem_size' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
size_t HashJoinBuildSinkLocalState::get_reserve_mem_size(RuntimeState*
state, bool eos) {
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/exec/hashjoin_build_sink.cpp:115:** 85 lines including
whitespace and comments (threshold 80)
```cpp
size_t HashJoinBuildSinkLocalState::get_reserve_mem_size(RuntimeState*
state, bool eos) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
