zclllyybb commented on code in PR #45159:
URL: https://github.com/apache/doris/pull/45159#discussion_r1877224039
##########
be/src/vec/functions/simple_function_factory.h:
##########
@@ -158,19 +167,21 @@ class SimpleFunctionFactory {
FunctionBasePtr get_function(const std::string& name, const
ColumnsWithTypeAndName& arguments,
const DataTypePtr& return_type, const
FunctionAttr& attr = {},
int be_version =
BeExecVersionManager::get_newest_version()) {
- std::string key_str = name;
+ std::string key_str, ori_name = name;
Review Comment:
split definition. use `origin_name`
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Date.java:
##########
Review Comment:
add regression-test about null
##########
be/src/vec/functions/simple_function_factory.h:
##########
@@ -158,19 +167,21 @@ class SimpleFunctionFactory {
FunctionBasePtr get_function(const std::string& name, const
ColumnsWithTypeAndName& arguments,
const DataTypePtr& return_type, const
FunctionAttr& attr = {},
int be_version =
BeExecVersionManager::get_newest_version()) {
- std::string key_str = name;
+ std::string key_str, ori_name = name;
Review Comment:
add comment on these two var
##########
gensrc/script/doris_builtins_functions.py:
##########
Review Comment:
revert this
##########
be/src/vec/functions/function.h:
##########
@@ -299,6 +299,10 @@ class FunctionBuilderImpl : public IFunctionBuilder {
ColumnNumbers get_arguments_that_are_always_constant() const override {
return {}; }
+ // if a function's get_variadic_argument_types() not override and
get_return_type_impl()
+ // result is not compile time be sure, the function should override return
true
+ virtual bool dont_append_return_type_name_when_register_function() {
return false; }
Review Comment:
impl it in `IFunctionBase`, so we can do check in function factory.
if not possible, add comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
