github-actions[bot] commented on code in PR #45217:
URL: https://github.com/apache/doris/pull/45217#discussion_r1877182420
##########
be/src/vec/exec/format/parquet/vparquet_reader.cpp:
##########
@@ -253,10 +253,8 @@ Status ParquetReader::_open_file() {
return Status::OK();
}
-// Get iceberg col id to col name map stored in parquet metadata key values.
-// This is for iceberg schema evolution.
-std::vector<tparquet::KeyValue> ParquetReader::get_metadata_key_values() {
- return _t_metadata->key_value_metadata;
+const FieldDescriptor ParquetReader::get_file_metadata_schema() {
Review Comment:
warning: return type 'const std::doris::vectorized::FieldDescriptor' is
'const'-qualified at the top level, which may reduce code readability without
improving const correctness [readability-const-return-type]
```suggestion
FieldDescriptor ParquetReader::get_file_metadata_schema() {
```
be/src/vec/exec/format/parquet/vparquet_reader.h:150:
```diff
- const FieldDescriptor get_file_metadata_schema();
+ FieldDescriptor get_file_metadata_schema();
```
##########
be/src/vec/exec/format/parquet/schema_desc.cpp:
##########
@@ -147,6 +150,14 @@ Status FieldDescriptor::parse_from_thrift(const
std::vector<tparquet::SchemaElem
return Status::OK();
}
+const doris::Slice FieldDescriptor::get_column_name_from_field_id(int32_t id)
const {
Review Comment:
warning: return type 'const doris::Slice' is 'const'-qualified at the top
level, which may reduce code readability without improving const correctness
[readability-const-return-type]
```suggestion
doris::Slice FieldDescriptor::get_column_name_from_field_id(int32_t id)
const {
```
be/src/vec/exec/format/parquet/schema_desc.h:136:
```diff
- const doris::Slice get_column_name_from_field_id(int32_t id) const;
+ doris::Slice get_column_name_from_field_id(int32_t id) const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
