github-actions[bot] commented on code in PR #41232:
URL: https://github.com/apache/doris/pull/41232#discussion_r1877069259
##########
be/src/olap/partial_update_info.cpp:
##########
@@ -169,55 +175,55 @@ std::string PartialUpdateInfo::summary() const {
max_version_in_flush_phase);
}
-Status PartialUpdateInfo::handle_not_found_error_for_fixed_partial_update(
- const TabletSchema& tablet_schema) const {
- if (!can_insert_new_rows_in_partial_update) {
- std::string error_column;
- for (auto cid : missing_cids) {
- const TabletColumn& col = tablet_schema.column(cid);
- if (!col.has_default_value() && !col.is_nullable() &&
- !(tablet_schema.auto_increment_column() == col.name())) {
- error_column = col.name();
- break;
+Status PartialUpdateInfo::handle_new_key(const TabletSchema& tablet_schema,
Review Comment:
warning: method 'handle_new_key' can be made const
[readability-make-member-function-const]
be/src/olap/partial_update_info.cpp:179:
```diff
- BitmapValue* skip_bitmap) {
+ BitmapValue* skip_bitmap) const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
