CalvinKirs opened a new pull request, #45176:
URL: https://github.com/apache/doris/pull/45176

   
   ### Abstract:
   In the current time window scheduling logic, the calculation of trigger 
times was not strictly aligned to the second level, which could lead to 
millisecond offsets. This offset caused issues such as consecutive trigger 
times at 14:56:59 and 14:57:00, disrupting the correctness of the scheduling.
   
   This PR optimizes the calculation of trigger times to ensure that time 
points are strictly aligned to the second level, preventing the accumulation of 
millisecond errors.
   
   ### Issue Description:
   
   Under a specified window (e.g., 14:50:00 to 14:59:00) and a fixed interval 
(e.g., every minute), the scheduler generated erroneous trigger times such as:
   
   ```
   | 2024-12-04 14:56:59 |
   | 2024-12-04 14:57:00 |
   | 2024-12-04 14:57:59 |
   | 2024-12-04 14:58:00 |
   ```
   #### Cause:
   The current firstTriggerTime and the loop calculation did not strictly align 
trigger times to the second level, resulting in erroneous trigger points due to 
floating-point or millisecond offset accumulation. The end condition for the 
time window was not aligned to the second level, which could lead to additional 
trigger times being included.
   
   ### Fix:
   Modification 1: Strictly align the trigger time to the second level.
   
   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to