morningman commented on code in PR #45103:
URL: https://github.com/apache/doris/pull/45103#discussion_r1874062658
##########
fe/fe-core/src/main/java/org/apache/doris/job/disruptor/TaskDisruptor.java:
##########
@@ -73,20 +73,37 @@ public void start() {
*/
public boolean publishEvent(Object... args) {
try {
- RingBuffer<T> ringBuffer = disruptor.getRingBuffer();
- // Check if the RingBuffer has enough capacity to reserve 10 slots
for tasks
- // If there is insufficient capacity (less than 10 slots available)
- // log a warning and drop the current task
- if (!ringBuffer.hasAvailableCapacity(10)) {
- LOG.warn("ring buffer has no available capacity,task will be
dropped,"
- + "please check the task queue size.");
- return false;
+ // Set the timeout to 1 second, converted to nanoseconds for
precision
+ long timeoutInNanos = TimeUnit.SECONDS.toNanos(1); // Timeout set
to 1 second
+ long startTime = System.nanoTime(); // Record the start time
+
+ // Loop until the timeout is reached
+ while (System.nanoTime() - startTime < timeoutInNanos) {
+ // Check if there is enough remaining capacity in the ring
buffer
+ // Adjusting to check if the required capacity is available
(instead of hardcoding 1)
+ if (disruptor.getRingBuffer().remainingCapacity() > 1) {
+ // Publish the event if there is enough capacity
+ disruptor.getRingBuffer().publishEvent(eventTranslator,
args);
+ return true;
+ }
+
+ // Wait for a short period before retrying
+ try {
+ Thread.sleep(10); // Adjust the wait time as needed
(maybe increase if not high-frequency)
+ } catch (InterruptedException e) {
+ // Log the exception and return false if interrupted
+ Thread.currentThread().interrupt(); // Restore interrupt
status
+ LOG.warn("Thread interrupted while waiting to publish
event", e);
+ return false;
+ }
}
- ringBuffer.publishEvent(eventTranslator, args);
- return true;
+
+ // Timeout reached without publishing the event
+ LOG.warn("Failed to publish event within the specified timeout (1
second)."
Review Comment:
In log, it should be `current size of the buffer`, not `remaining size of
the buffer`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
