stalary commented on PR #9725: URL: https://github.com/apache/incubator-doris/pull/9725#issuecomment-1135515892
> @stalary In the lastest commit I separate the interface `getProfile(queryId)` into two parts of `getProfileContent` and `getProfileBuilder`. Since if we want to store the record in a db system and read the big field to construct the `ProfileBuilder` instance, it maybe a heave thing if we only want to list the record or get the query profile content. > > But it maybe take a new disadvantage that if we want to add more filed into query profile, it has to add a new method instead of add a filed in `ProfileElemt`. It may cause the number of methods loss control. > > Which one do you think is better? I think it's ok to return enough data at the bottom level for the top level to choose. This will be easier to extend later when we support more storage methods. So in my opinion, split is not necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
