morrySnow commented on code in PR #44943:
URL: https://github.com/apache/doris/pull/44943#discussion_r1870714427
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/DayCeil.java:
##########
@@ -106,4 +107,19 @@ public List<FunctionSignature> getSignatures() {
public <R, C> R accept(ExpressionVisitor<R, C> visitor, C context) {
return visitor.visitDayCeil(this, context);
}
+
+ @Override
+ public Expression withConstantArgs(Expression literal) {
+ switch (arity()) {
+ case 1:
+ return new DayCeil(literal);
+ case 2:
+ return new DayCeil(literal, child(1));
+ case 3:
+ return new DayCeil(literal, child(1), child(2));
+ default:
+ // should not reach
+ return null;
Review Comment:
1. Do LOG
2. throw exception or check null in caller
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
