This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch auto-pick-44552-branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/auto-pick-44552-branch-3.0 by
this push:
new b43cf4fb8a5 [test](move-memtable) fix false positives in sinkv2
injection tests (#44552)
b43cf4fb8a5 is described below
commit b43cf4fb8a575fd96848a990883ff096dae7aed3
Author: Kaijie Chen <chenkai...@selectdb.com>
AuthorDate: Tue Dec 3 18:52:16 2024 +0800
[test](move-memtable) fix false positives in sinkv2 injection tests (#44552)
`test_writer_v2_fault_injection` did not assert Exception being thrown,
which caused false positives.
i.e. Code bugged but test passed.
This PR fixed this problem.
Run this test without #44344, it will now report errors as expected.
```
2024-11-25 17:03:25.463 ERROR [non-concurrent-thread-1]
(ScriptContext.groovy:122) - Run test_writer_v2_fault_injection in
./doris/regression-test/suites/fault_injection_p0/test_writer_v2_fault_injection.groovy
failed
org.opentest4j.AssertionFailedError: expected Exception 'load timed out
before close waiting', actual success ==> expected: <true> but was: <false>
```
---
.../suites/fault_injection_p0/test_writer_v2_fault_injection.groovy | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
a/regression-test/suites/fault_injection_p0/test_writer_v2_fault_injection.groovy
b/regression-test/suites/fault_injection_p0/test_writer_v2_fault_injection.groovy
index f05a084035c..7e71de173e9 100644
---
a/regression-test/suites/fault_injection_p0/test_writer_v2_fault_injection.groovy
+++
b/regression-test/suites/fault_injection_p0/test_writer_v2_fault_injection.groovy
@@ -67,10 +67,11 @@ suite("test_writer_v2_fault_injection", "nonConcurrent") {
file "baseall.txt"
}
- def load_with_injection = { injection, error_msg->
+ def load_with_injection = { injection, error_msg, success=false->
try {
GetDebugPoint().enableDebugPointForAllBEs(injection)
sql "insert into test select * from baseall where k1 <= 3"
+ assertTrue(success, String.format("expected Exception '%s', actual
success", error_msg))
} catch(Exception e) {
logger.info(e.getMessage())
assertTrue(e.getMessage().contains(error_msg),
@@ -88,7 +89,7 @@ suite("test_writer_v2_fault_injection", "nonConcurrent") {
// VTabletWriterV2 node_info is null
load_with_injection("VTabletWriterV2._open_streams_to_backend.node_info_null",
"failed to open streams to any BE")
// VTabletWriterV2 do not get tablet schema on open_streams
-
load_with_injection("VTabletWriterV2._open_streams_to_backend.no_schema_when_open_streams",
"success")
+
load_with_injection("VTabletWriterV2._open_streams_to_backend.no_schema_when_open_streams",
"success", true)
// VTabletWriterV2 tablet_location is null
load_with_injection("VTabletWriterV2._build_tablet_node_mapping.tablet_location_null",
"unknown tablet location")
// VTabletWriterV2 location is null
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
