gavinchou commented on code in PR #44780:
URL: https://github.com/apache/doris/pull/44780#discussion_r1867227520
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -1310,15 +1310,24 @@ void internal_get_rowset(Transaction* txn, int64_t
start, int64_t end,
while (it->has_next()) {
auto [k, v] = it->next();
- auto rs = response->add_rowset_meta();
+ auto* rs = response->add_rowset_meta();
+ auto byte_size = rs->ByteSizeLong();
+ if (byte_size + v.size() > std::numeric_limits<int32_t>::max()) {
Review Comment:
add an UT, and print size of repeated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
