HappenLee commented on code in PR #44618:
URL: https://github.com/apache/doris/pull/44618#discussion_r1866973518
##########
be/src/vec/runtime/shared_hash_table_controller.h:
##########
@@ -90,15 +104,29 @@ class SharedHashTableController {
_dependencies[node_id].push_back(dep);
_finish_dependencies[node_id].push_back(finish_dep);
}
+};
-private:
- std::mutex _mutex;
- // For pipelineX, we update all dependencies once hash table is built;
- std::map<int /*node id*/,
std::vector<std::shared_ptr<pipeline::Dependency>>> _dependencies;
- std::map<int /*node id*/,
std::vector<std::shared_ptr<pipeline::Dependency>>>
- _finish_dependencies;
- std::map<int /*node id*/, TUniqueId /*fragment instance id*/>
_builder_fragment_ids;
- std::map<int /*node id*/, SharedHashTableContextPtr> _shared_contexts;
+struct SharedCollectedDataContext {
Review Comment:
Add comment for the code. what's `CollectedData`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
