(doris) 01/01: fix publish not inited rf when broadcast join meet wake up by downsteam

[panxiaolei]

This is an automated email from the ASF dual-hosted git repository.

panxiaolei pushed a commit to branch cp_1202
in repository https://gitbox.apache.org/repos/asf/doris.git

commit 3071cb4c9b0c3a19b181efc7738d19bdd7d97e5d
Author: BiteTheDDDDt <pxl...@qq.com>
AuthorDate: Mon Dec 2 15:49:58 2024 +0800

    fix publish not inited rf when broadcast join meet wake up by downsteam
---
 be/src/pipeline/exec/hashjoin_build_sink.cpp | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/be/src/pipeline/exec/hashjoin_build_sink.cpp 
b/be/src/pipeline/exec/hashjoin_build_sink.cpp
index 500ec6e0365..dff377d62d5 100644
--- a/be/src/pipeline/exec/hashjoin_build_sink.cpp
+++ b/be/src/pipeline/exec/hashjoin_build_sink.cpp
@@ -142,19 +142,23 @@ Status HashJoinBuildSinkLocalState::close(RuntimeState* 
state, Status exec_statu
     }
 
     if (state->get_task()->wake_up_by_downstream()) {
-        RETURN_IF_ERROR(_runtime_filter_slots->send_filter_size(state, 0, 
_finish_dependency));
-        RETURN_IF_ERROR(_runtime_filter_slots->ignore_all_filters());
-    } else {
+        if (_should_build_hash_table) {
+            // partitial ignore rf to make global rf work
+            RETURN_IF_ERROR(_runtime_filter_slots->send_filter_size(state, 0, 
_finish_dependency));
+            RETURN_IF_ERROR(_runtime_filter_slots->ignore_all_filters());
+        } else {
+            // do not publish filter coz local rf not inited and useless
+            return Base::close(state, exec_status);
+        }
+    } else if (_should_build_hash_table) {
         auto* block = _shared_state->build_block.get();
         uint64_t hash_table_size = block ? block->rows() : 0;
         {
             SCOPED_TIMER(_runtime_filter_init_timer);
-            if (_should_build_hash_table) {
-                RETURN_IF_ERROR(_runtime_filter_slots->init_filters(state, 
hash_table_size));
-            }
+            RETURN_IF_ERROR(_runtime_filter_slots->init_filters(state, 
hash_table_size));
             RETURN_IF_ERROR(_runtime_filter_slots->ignore_filters(state));
         }
-        if (_should_build_hash_table && hash_table_size > 1) {
+        if (hash_table_size > 1) {
             SCOPED_TIMER(_runtime_filter_compute_timer);
             _runtime_filter_slots->insert(block);
         }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org