(doris) 01/01: [fix](catalog) Fix infinity partition key toSql

[w41ter]

This is an automated email from the ASF dual-hosted git repository.

w41ter pushed a commit to branch fix_infinity_partition_key_to_sql
in repository https://gitbox.apache.org/repos/asf/doris.git

commit cd22ad1cf0fe953ec4800c69a21ced5b78d66612
Author: w41ter <maoch...@selectdb.com>
AuthorDate: Mon Dec 2 02:09:40 2024 +0000

    [fix](catalog) Fix infinity partition key toSql
---
 fe/fe-core/src/main/java/org/apache/doris/catalog/PartitionKey.java | 3 +--
 .../src/test/java/org/apache/doris/catalog/PartitionKeyTest.java    | 6 ++++++
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/catalog/PartitionKey.java 
b/fe/fe-core/src/main/java/org/apache/doris/catalog/PartitionKey.java
index f9640ccae14..29bfda8b201 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/catalog/PartitionKey.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/PartitionKey.java
@@ -373,15 +373,14 @@ public class PartitionKey implements 
Comparable<PartitionKey>, Writable {
             if (expr == MaxLiteral.MAX_VALUE || expr.isNullLiteral()) {
                 value = expr.toSql();
                 sb.append(value);
-                continue;
             } else {
                 value = "\"" + expr.getRealValue() + "\"";
                 if (expr instanceof DateLiteral) {
                     DateLiteral dateLiteral = (DateLiteral) expr;
                     value = dateLiteral.toSql();
                 }
+                sb.append(value);
             }
-            sb.append(value);
 
             if (keys.size() - 1 != i) {
                 sb.append(", ");
diff --git 
a/fe/fe-core/src/test/java/org/apache/doris/catalog/PartitionKeyTest.java 
b/fe/fe-core/src/test/java/org/apache/doris/catalog/PartitionKeyTest.java
index affd5a4cc2c..c6b45c0b136 100644
--- a/fe/fe-core/src/test/java/org/apache/doris/catalog/PartitionKeyTest.java
+++ b/fe/fe-core/src/test/java/org/apache/doris/catalog/PartitionKeyTest.java
@@ -268,4 +268,10 @@ public class PartitionKeyTest {
         dis.close();
         Files.deleteIfExists(path);
     }
+
+    @Test
+    public void testMaxValueToSql() throws Exception {
+        PartitionKey key = PartitionKey.createInfinityPartitionKey(allColumns, 
true);
+        Assert.assertEquals("(MAXVALUE, MAXVALUE, MAXVALUE, MAXVALUE, 
MAXVALUE, MAXVALUE, MAXVALUE)", key.toSql());
+    }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org