xinyiZzz commented on code in PR #44739:
URL: https://github.com/apache/doris/pull/44739#discussion_r1863343198


##########
be/src/olap/segment_loader.h:
##########
@@ -75,9 +75,15 @@ class SegmentCache : public LRUCachePolicy {
     // Holding all opened segments of a rowset.
     class CacheValue : public LRUCacheValueBase {
     public:
-        ~CacheValue() override { segment.reset(); }
+        CacheValue(segment_v2::SegmentSharedPtr segment_) : 
segment(std::move(segment_)) {
+            // Transfer to segment cache memory tracker.
+            
ExecEnv::GetInstance()->all_segments_mem_tracker()->release(segment->meta_mem_usage());

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to