morningman commented on code in PR #44267:
URL: https://github.com/apache/doris/pull/44267#discussion_r1862327637
##########
be/src/vec/exec/format/table/hudi_jni_reader.cpp:
##########
@@ -65,16 +65,21 @@ HudiJniReader::HudiJniReader(const TFileScanRangeParams&
scan_params,
{"input_format", _hudi_params.input_format}};
// Use compatible hadoop client to read data
- for (auto& kv : _scan_params.properties) {
+ for (const auto& kv : _scan_params.properties) {
if (kv.first.starts_with(HOODIE_CONF_PREFIX)) {
params[kv.first] = kv.second;
} else {
params[HADOOP_CONF_PREFIX + kv.first] = kv.second;
}
}
- _jni_connector =
std::make_unique<JniConnector>("org/apache/doris/hudi/HudiJniScanner", params,
- required_fields);
+ if (config::use_old_hudi_jni_reader) [[unlikely]] {
Review Comment:
Better use a session variable
set hudi_jni_scanner = "spark" or "hadoop".
and default is hadoop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
