morningman commented on code in PR #44615:
URL: https://github.com/apache/doris/pull/44615#discussion_r1862315775
##########
be/src/vec/exec/format/orc/vorc_reader.cpp:
##########
@@ -624,15 +625,37 @@ std::tuple<bool, orc::Literal, orc::PredicateDataType>
OrcReader::_make_orc_lite
}
}
-// check if the slot of expr can be pushed down to orc reader
+// check if the slot of expr can be pushed down to orc reader and make orc
predicate type
bool OrcReader::_check_slot_can_push_down(const VExprSPtr& expr) {
if (!expr->children()[0]->is_slot_ref()) {
return false;
}
const auto* slot_ref = static_cast<const
VSlotRef*>(expr->children()[0].get());
// check if the slot exists in orc file and not partition column
- return _col_name_to_file_col_name.contains(slot_ref->expr_name()) &&
-
!_lazy_read_ctx.predicate_partition_columns.contains(slot_ref->expr_name());
+ if (!_col_name_to_file_col_name.contains(slot_ref->expr_name()) &&
Review Comment:
```suggestion
if (!_col_name_to_file_col_name.contains(slot_ref->expr_name()) ||
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
