This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 6ba91dc39c7 [fix](runtime filter) Avoid to use ignored runtime filter
(#44708)
6ba91dc39c7 is described below
commit 6ba91dc39c763018f9030b877b435aa9ea704c28
Author: Gabriel <liwenqi...@selectdb.com>
AuthorDate: Thu Nov 28 13:38:10 2024 +0800
[fix](runtime filter) Avoid to use ignored runtime filter (#44708)
### What problem does this PR solve?
Filter size should be set by a global size instead of a local size. This
behaviour is introduced by #43885 .
---
be/src/exprs/runtime_filter.cpp | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/be/src/exprs/runtime_filter.cpp b/be/src/exprs/runtime_filter.cpp
index 6eed49e8567..efe96ae3395 100644
--- a/be/src/exprs/runtime_filter.cpp
+++ b/be/src/exprs/runtime_filter.cpp
@@ -1114,9 +1114,6 @@ Status IRuntimeFilter::send_filter_size(RuntimeState*
state, uint64_t local_filt
std::lock_guard l(*local_merge_filters->lock);
local_merge_filters->merge_size_times--;
local_merge_filters->local_merged_size += local_filter_size;
- if (_has_local_target) {
- set_synced_size(local_filter_size);
- }
if (local_merge_filters->merge_size_times) {
return Status::OK();
} else {
@@ -1539,9 +1536,10 @@ void
IRuntimeFilter::update_runtime_filter_type_to_profile(uint64_t local_merge_
std::string IRuntimeFilter::debug_string() const {
return fmt::format(
"RuntimeFilter: (id = {}, type = {}, is_broadcast: {}, "
- "build_bf_cardinality: {}, error_msg: {}",
+ "build_bf_cardinality: {}, ignored: {}, error_msg: {}",
_filter_id, to_string(_runtime_filter_type), _is_broadcast_join,
- _wrapper->get_build_bf_cardinality(), _wrapper->_context->err_msg);
+ _wrapper->get_build_bf_cardinality(), _wrapper->is_ignored(),
+ _wrapper->_context->err_msg);
}
Status IRuntimeFilter::merge_from(const RuntimePredicateWrapper* wrapper) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
