starocean999 commented on code in PR #44298:
URL: https://github.com/apache/doris/pull/44298#discussion_r1860217497
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -4159,6 +4162,23 @@ public Object visitRefreshCatalog(RefreshCatalogContext
ctx) {
}
@Override
+ public RefreshDatabaseCommand visitRefreshDatabase(RefreshDatabaseContext
ctx) {
+ Map<String, String> properties =
visitPropertyClause(ctx.propertyClause()) == null ? Maps.newHashMap()
+ : visitPropertyClause(ctx.propertyClause());
+ List<String> parts = visitMultipartIdentifier(ctx.name);
+ int size = parts.size();
+ Preconditions.checkArgument(size > 0, "database name can't be empty");
Review Comment:
throw new ParseException
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -4159,6 +4162,23 @@ public Object visitRefreshCatalog(RefreshCatalogContext
ctx) {
}
@Override
+ public RefreshDatabaseCommand visitRefreshDatabase(RefreshDatabaseContext
ctx) {
+ Map<String, String> properties =
visitPropertyClause(ctx.propertyClause()) == null ? Maps.newHashMap()
+ : visitPropertyClause(ctx.propertyClause());
+ List<String> parts = visitMultipartIdentifier(ctx.name);
+ int size = parts.size();
+ Preconditions.checkArgument(size > 0, "database name can't be empty");
+ String dbName = parts.get(size - 1);
+
+ // [db].
+ if (size == 1) {
+ return new RefreshDatabaseCommand(dbName, properties);
+ } else if (parts.size() == 2) { // [ctl,db].
+ return new RefreshDatabaseCommand(parts.get(0), dbName,
properties);
+ }
+ throw new IllegalArgumentException("Only one dot can be in the name: "
+ String.join(".", parts));
Review Comment:
throw new ParseException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
