dataroaring commented on code in PR #9586:
URL: https://github.com/apache/incubator-doris/pull/9586#discussion_r874683913
##########
be/src/vec/columns/column_dictionary.h:
##########
@@ -301,13 +296,17 @@ class ColumnDictionary final : public COWHelper<IColumn,
ColumnDictionary<T>> {
if (it != _inverted_index.end()) {
return it->second;
}
- return -1;
+ return -2; // -1 is null code
}
- inline StringValue& get_value(T code) { return _dict_data[code]; }
+ T get_null_code() { return -1; }
+
+ inline StringValue& get_value(T code) {
+ return code >= _dict_data.size() ? _null_value : _dict_data[code];
+ }
Review Comment:
So, this does not work now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
