xzj7019 commented on code in PR #43391:
URL: https://github.com/apache/doris/pull/43391#discussion_r1858343758
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalJoin.java:
##########
@@ -535,10 +535,13 @@ public void computeUniform(Builder builder) {
// TODO disable function dependence calculation for mark join, but
need re-think this in future.
return;
}
- if (!joinType.isLeftSemiOrAntiJoin()) {
+ // outer join cant have nullable side uniform properties
+ // (e.g. left join may produce null in right side, the uniform value
is present and not null
+ // cannot deduce the slot is uniform and not null)
+ if (!joinType.isLeftJoin()) {
Review Comment:
make sure the null prop lost will not impact current opt rules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
