This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new 1b34ae3574a branch-3.0: [improve][ms] Bvars add the FDB
get_count_normalized indicator #44036 (#44350)
1b34ae3574a is described below
commit 1b34ae3574a26cba0a58f7cdd4a864ad6e2bf3e1
Author: github-actions[bot]
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Tue Nov 26 19:13:27 2024 +0800
branch-3.0: [improve][ms] Bvars add the FDB get_count_normalized indicator
#44036 (#44350)
Cherry-picked from #44036
Co-authored-by: jw-sun <55874234+sjwhe...@users.noreply.github.com>
Co-authored-by: sunjiangwei <sunjiang...@meituan.com>
---
cloud/src/common/bvars.cpp | 2 ++
cloud/src/common/bvars.h | 1 +
cloud/src/meta-service/txn_kv.cpp | 3 +++
3 files changed, 6 insertions(+)
diff --git a/cloud/src/common/bvars.cpp b/cloud/src/common/bvars.cpp
index 2e2e312d0c1..507acb00dff 100644
--- a/cloud/src/common/bvars.cpp
+++ b/cloud/src/common/bvars.cpp
@@ -102,6 +102,8 @@ bvar::LatencyRecorder
g_bvar_txn_kv_get_read_version("txn_kv", "get_read_version
bvar::LatencyRecorder g_bvar_txn_kv_get_committed_version("txn_kv",
"get_committed_version");
bvar::LatencyRecorder g_bvar_txn_kv_batch_get("txn_kv", "batch_get");
+bvar::Adder<int64_t> g_bvar_txn_kv_get_count_normalized("txn_kv",
"get_count_normalized");
+
bvar::Adder<int64_t> g_bvar_txn_kv_commit_error_counter;
bvar::Window<bvar::Adder<int64_t> > g_bvar_txn_kv_commit_error_counter_minute(
"txn_kv", "commit_error", &g_bvar_txn_kv_commit_error_counter, 60);
diff --git a/cloud/src/common/bvars.h b/cloud/src/common/bvars.h
index c2e21c66daa..373a3a63ff2 100644
--- a/cloud/src/common/bvars.h
+++ b/cloud/src/common/bvars.h
@@ -198,6 +198,7 @@ extern bvar::LatencyRecorder g_bvar_txn_kv_batch_get;
extern bvar::Adder<int64_t> g_bvar_txn_kv_commit_error_counter;
extern bvar::Adder<int64_t> g_bvar_txn_kv_commit_conflict_counter;
+extern bvar::Adder<int64_t> g_bvar_txn_kv_get_count_normalized;
extern const int64_t BVAR_FDB_INVALID_VALUE;
extern bvar::Status<int64_t> g_bvar_fdb_client_count;
diff --git a/cloud/src/meta-service/txn_kv.cpp
b/cloud/src/meta-service/txn_kv.cpp
index f40bee76f7a..ea31d5cb97b 100644
--- a/cloud/src/meta-service/txn_kv.cpp
+++ b/cloud/src/meta-service/txn_kv.cpp
@@ -377,6 +377,7 @@ TxnErrorCode Transaction::get(std::string_view key,
std::string* val, bool snaps
approximate_bytes_ += key.size() * 2; // See
fdbclient/ReadYourWrites.actor.cpp for details
auto* fut = fdb_transaction_get(txn_, (uint8_t*)key.data(), key.size(),
snapshot);
+ g_bvar_txn_kv_get_count_normalized << 1;
auto release_fut = [fut, &sw](int*) {
fdb_future_destroy(fut);
g_bvar_txn_kv_get << sw.elapsed_us();
@@ -434,6 +435,7 @@ TxnErrorCode Transaction::get(std::string_view begin,
std::string_view end,
std::unique_ptr<RangeGetIterator> ret(new RangeGetIterator(fut));
RETURN_IF_ERROR(ret->init());
+ g_bvar_txn_kv_get_count_normalized << ret->size();
*(iter) = std::move(ret);
@@ -619,6 +621,7 @@ TxnErrorCode
Transaction::batch_get(std::vector<std::optional<std::string>>* res
size_t num_keys = keys.size();
res->reserve(keys.size());
+ g_bvar_txn_kv_get_count_normalized << keys.size();
std::vector<std::unique_ptr<FDBFuture, FDBFutureDelete>> futures;
futures.reserve(opts.concurrency);
for (size_t i = 0; i < num_keys; i += opts.concurrency) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
