This is an automated email from the ASF dual-hosted git repository.
gabriellee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new aa92038a557 [fix](runtime filter) Fix unreasonable wrong status
(#44545)
aa92038a557 is described below
commit aa92038a55779497b0e0f5c3f4eb1805030e559a
Author: Gabriel <liwenqi...@selectdb.com>
AuthorDate: Mon Nov 25 20:53:36 2024 +0800
[fix](runtime filter) Fix unreasonable wrong status (#44545)
Introduced by #43627
Query could be finished when runtime filter was sent to a global runtime
filter merger. Here we should return `EOF` status instead of
`InvalidArgument`.
---
be/src/runtime/fragment_mgr.cpp | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/be/src/runtime/fragment_mgr.cpp b/be/src/runtime/fragment_mgr.cpp
index 16b75794511..47b007edf5d 100644
--- a/be/src/runtime/fragment_mgr.cpp
+++ b/be/src/runtime/fragment_mgr.cpp
@@ -1292,8 +1292,8 @@ Status FragmentMgr::sync_filter_size(const
PSyncFilterSizeRequest* request) {
if (auto q_ctx = _get_or_erase_query_ctx(query_id)) {
query_ctx = q_ctx;
} else {
- return Status::InvalidArgument(
- "Sync filter size failed: Query context (query-id: {}) not
found",
+ return Status::EndOfFile(
+ "Sync filter size failed: Query context (query-id: {})
already finished",
queryid.to_string());
}
}
@@ -1313,8 +1313,8 @@ Status FragmentMgr::merge_filter(const
PMergeFilterRequest* request,
if (auto q_ctx = _get_or_erase_query_ctx(query_id)) {
query_ctx = q_ctx;
} else {
- return Status::InvalidArgument(
- "Merge filter size failed: Query context (query-id: {})
not found",
+ return Status::EndOfFile(
+ "Merge filter size failed: Query context (query-id: {})
already finished",
queryid.to_string());
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
