Re: [PR] [Improvement]downgrade resource tag when there is not queryable replica [doris]

[via GitHub]

yiguolei commented on code in PR #44255:
URL: https://github.com/apache/doris/pull/44255#discussion_r1855979939


##########
fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java:
##########
@@ -890,6 +890,16 @@ private void addScanRangeLocations(Partition partition,
 
             int replicaInTablet = 0;
             long oneReplicaBytes = 0;
+
+
+            // when resource tag has no alive replica and 
allowResourceTagDowngrade = true,
+            // resource tag should be disabled, we should find at least one 
alive replica
+            boolean shouldSkipResourceTag = false;
+            boolean isAllowRgDowngrade = context.isAllowResourceTagDowngrade();
+            if (needCheckTags && isAllowRgDowngrade && 
!checkTagHasAvailReplica(allowedTags, replicas)) {
+                shouldSkipResourceTag = true;

Review Comment:
   need log here， to print skip resource tag and the query id



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org