yiguolei commented on code in PR #9610:
URL: https://github.com/apache/incubator-doris/pull/9610#discussion_r874433661
##########
be/src/vec/olap/vcollect_iterator.cpp:
##########
@@ -55,7 +55,8 @@ void
VCollectIterator::build_heap(std::vector<RowsetReaderSharedPtr>& rs_readers
DCHECK(!rs_readers.empty());
for (auto [c_iter, r_iter] = std::pair {_children.begin(),
rs_readers.begin()};
c_iter != _children.end();) {
- if ((*c_iter)->init() != Status::OK()) {
+ auto s = (*c_iter)->init();
+ if (!s.ok() && s.precise_code() != OLAP_ERR_DATA_EOF) {
delete (*c_iter);
Review Comment:
Need to return an error status here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
