github-actions[bot] commented on code in PR #44454:
URL: https://github.com/apache/doris/pull/44454#discussion_r1853317368
##########
be/src/vec/runtime/vdatetime_value.cpp:
##########
@@ -683,8 +684,8 @@ char* write_four_digits_to_string(int number, char* dst) {
return dst + 4;
}
-bool VecDateTimeValue::to_format_string_conservative(const char* format, int
len, char* to,
- int max_valid_length)
const {
+bool VecDateTimeValue::to_format_string_conservative(const char* format,
size_t len, char* to,
Review Comment:
warning: function 'to_format_string_conservative' has cognitive complexity
of 60 (threshold 50) [readability-function-cognitive-complexity]
```cpp
bool VecDateTimeValue::to_format_string_conservative(const char* format,
size_t len, char* to,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/runtime/vdatetime_value.cpp:688:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (check_range(_year, _month, _day, _hour, _minute, _second, _type)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:699:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
while (ptr < end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:700:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (to - begin + SAFE_FORMAT_STRING_MARGIN > max_valid_length)
[[unlikely]] {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:703:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (*ptr != '%' || (ptr + 1) == end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:703:** +1
```cpp
if (*ptr != '%' || (ptr + 1) == end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:709:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
switch (ch = *ptr++) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:760:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_type == TIME_TIME || (_year == 0 && _month == 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:760:** +1
```cpp
if (_type == TIME_TIME || (_year == 0 && _month == 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:760:** +1
```cpp
if (_type == TIME_TIME || (_year == 0 && _month == 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:767:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_month == 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:781:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_day >= 10 && _day <= 19) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:781:** +1
```cpp
if (_day >= 10 && _day <= 19) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:783:** +1, nesting level increased
to 3
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:784:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
switch (_day % 10) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:827:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_month == 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:834:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if ((_hour % 24) >= 12) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:836:** +1, nesting level increased
to 3
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:852:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if ((_hour % 24) >= 12) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:854:** +1, nesting level increased
to 3
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:874:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_type == TIME_TIME) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:884:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_type == TIME_TIME) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:894:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_type == TIME_TIME) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:904:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_type == TIME_TIME) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:913:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_type == TIME_TIME || (_month == 0 && _year == 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:913:** +1
```cpp
if (_type == TIME_TIME || (_month == 0 && _year == 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:913:** +1
```cpp
if (_type == TIME_TIME || (_month == 0 && _year == 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:926:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_type == TIME_TIME) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:939:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_type == TIME_TIME) {
^
```
</details>
##########
be/src/vec/runtime/vdatetime_value.cpp:
##########
@@ -1992,19 +1993,19 @@
// YYYY-MM-DD HH-MM-DD.FFFFFF AM in default format
// 0 1 2 3 4 5 6 7
template <typename T>
-bool DateV2Value<T>::from_date_str(const char* date_str, int len, int scale /*
= -1*/,
+bool DateV2Value<T>::from_date_str(const char* date_str, size_t len, int scale
/* = -1*/,
bool convert_zero) {
return from_date_str_base(date_str, len, scale, nullptr, convert_zero);
}
template <typename T>
-bool DateV2Value<T>::from_date_str(const char* date_str, int len,
+bool DateV2Value<T>::from_date_str(const char* date_str, size_t len,
const cctz::time_zone& local_time_zone, int
scale /* = -1*/,
bool convert_zero) {
return from_date_str_base(date_str, len, scale, &local_time_zone,
convert_zero);
}
// if local_time_zone is null, only be able to parse time without timezone
template <typename T>
-bool DateV2Value<T>::from_date_str_base(const char* date_str, int len, int
scale,
+bool DateV2Value<T>::from_date_str_base(const char* date_str, size_t len, int
scale,
Review Comment:
warning: function 'from_date_str_base' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
bool DateV2Value<T>::from_date_str_base(const char* date_str, size_t len,
int scale,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/runtime/vdatetime_value.cpp:2007:** 238 lines including
whitespace and comments (threshold 80)
```cpp
bool DateV2Value<T>::from_date_str_base(const char* date_str, size_t len,
int scale,
^
```
</details>
##########
be/src/vec/runtime/vdatetime_value.cpp:
##########
@@ -1992,19 +1993,19 @@
// YYYY-MM-DD HH-MM-DD.FFFFFF AM in default format
// 0 1 2 3 4 5 6 7
template <typename T>
-bool DateV2Value<T>::from_date_str(const char* date_str, int len, int scale /*
= -1*/,
+bool DateV2Value<T>::from_date_str(const char* date_str, size_t len, int scale
/* = -1*/,
bool convert_zero) {
return from_date_str_base(date_str, len, scale, nullptr, convert_zero);
}
template <typename T>
-bool DateV2Value<T>::from_date_str(const char* date_str, int len,
+bool DateV2Value<T>::from_date_str(const char* date_str, size_t len,
const cctz::time_zone& local_time_zone, int
scale /* = -1*/,
bool convert_zero) {
return from_date_str_base(date_str, len, scale, &local_time_zone,
convert_zero);
}
// if local_time_zone is null, only be able to parse time without timezone
template <typename T>
-bool DateV2Value<T>::from_date_str_base(const char* date_str, int len, int
scale,
+bool DateV2Value<T>::from_date_str_base(const char* date_str, size_t len, int
scale,
Review Comment:
warning: function 'from_date_str_base' has cognitive complexity of 116
(threshold 50) [readability-function-cognitive-complexity]
```cpp
bool DateV2Value<T>::from_date_str_base(const char* date_str, size_t len,
int scale,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/runtime/vdatetime_value.cpp:2017:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
while (ptr < end && check_space(*ptr)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2017:** +1
```cpp
while (ptr < end && check_space(*ptr)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2020:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (ptr == end || !isdigit(*ptr)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2020:** +1
```cpp
if (ptr == end || !isdigit(*ptr)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2025:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
while (pos < end && (isdigit(*pos) || *pos == 'T')) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2025:** +1
```cpp
while (pos < end && (isdigit(*pos) || *pos == 'T')) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2025:** +1
```cpp
while (pos < end && (isdigit(*pos) || *pos == 'T')) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2035:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (pos == end || *pos == '.' ||
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2035:** +1
```cpp
if (pos == end || *pos == '.' ||
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2037:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (digits == 4 || digits == 8 || digits >= 14) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2037:** +1
```cpp
if (digits == 4 || digits == 8 || digits >= 14) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2039:** +1, nesting level increased
to 2
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2050:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
while (ptr < end && isdigit(*ptr) && field_idx < MAX_DATE_PARTS) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2050:** +1
```cpp
while (ptr < end && isdigit(*ptr) && field_idx < MAX_DATE_PARTS) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2053:** +1
```cpp
bool scan_to_delim = (!is_interval_format) && (field_idx != 6);
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2054:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
while (ptr < end && isdigit(*ptr) && (scan_to_delim || field_len--))
{ // field_len <= 7
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2054:** +1
```cpp
while (ptr < end && isdigit(*ptr) && (scan_to_delim || field_len--))
{ // field_len <= 7
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2054:** +1
```cpp
while (ptr < end && isdigit(*ptr) && (scan_to_delim || field_len--))
{ // field_len <= 7
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2059:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (ptr == start) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2063:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (field_idx == 6) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2064:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if constexpr (is_datetime) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2069:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (scale >= 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2080:** +5, including nesting
penalty of 4, nesting level increased to 5
```cpp
if (reminder >= 5 * normalizer) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2085:** +5, including nesting
penalty of 4, nesting level increased to 5
```cpp
if (temp_val == int_exp10(7)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2088:** +1, nesting level increased
to 5
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2094:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
while (ptr < end && isdigit(*ptr)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2094:** +1
```cpp
while (ptr < end && isdigit(*ptr)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2097:** +1, nesting level increased
to 3
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2105:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (temp_val > 999999L) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2111:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (field_idx == 6) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2115:** +1, nesting level increased
to 2
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2121:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (ptr == end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2127:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (UNLIKELY((field_idx > 2 ||
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2129:** +1
```cpp
&& time_zone_begins(ptr, end))) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2127:** +1
```cpp
if (UNLIKELY((field_idx > 2 ||
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2130:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (local_time_zone == nullptr) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2138:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (field_idx == 2 && *ptr == 'T') {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2138:** +1
```cpp
if (field_idx == 2 && *ptr == 'T') {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2146:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (field_idx == 5) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2147:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (*ptr == '.') {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2152:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if constexpr (is_datetime) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2154:** +1, nesting level increased
to 4
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2157:** +1, nesting level increased
to 3
```cpp
} else if (isdigit(*ptr)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2165:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
while (ptr < end && (check_date_punct(*ptr) || check_space(*ptr))) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2165:** +1
```cpp
while (ptr < end && (check_date_punct(*ptr) || check_space(*ptr))) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2165:** +1
```cpp
while (ptr < end && (check_date_punct(*ptr) || check_space(*ptr))) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2166:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (check_space(*ptr)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2167:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (((1 << field_idx) & allow_space_mask) == 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2171:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (*ptr == '-') {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2180:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (!is_interval_format) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2183:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
for (; field_idx < MAX_DATE_PARTS; ++field_idx) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2187:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (year_len == 2) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2188:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (date_val[0] < YY_PART_YEAR) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2190:** +1, nesting level increased
to 2
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2195:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (num_field < 3) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2198:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (is_invalid(date_val[0], date_val[1], date_val[2], 0, 0, 0, 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2199:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (date_val[0] == 0 && date_val[1] == 0 && date_val[2] == 0 &&
convert_zero) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2199:** +1
```cpp
if (date_val[0] == 0 && date_val[1] == 0 && date_val[2] == 0 &&
convert_zero) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2202:** +1, nesting level increased
to 2
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2207:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (need_use_timezone) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2209:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (!TimezoneUtils::find_cctz_time_zone(std::string {ptr, end},
given_tz)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2222:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if constexpr (!is_datetime) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2223:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (sec_offset) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2225:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (!tmp.check_range_and_set_time(date_val[0], date_val[1],
date_val[2], date_val[3],
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2229:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (!tmp.date_add_interval<TimeUnit::SECOND>(
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2238:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (!check_range_and_set_time(date_val[0], date_val[1], date_val[2],
date_val[3], date_val[4],
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2243:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
return sec_offset ? date_add_interval<TimeUnit::SECOND>(
^
```
</details>
##########
be/src/vec/runtime/vdatetime_value.cpp:
##########
@@ -683,8 +684,8 @@
return dst + 4;
}
-bool VecDateTimeValue::to_format_string_conservative(const char* format, int
len, char* to,
- int max_valid_length)
const {
+bool VecDateTimeValue::to_format_string_conservative(const char* format,
size_t len, char* to,
Review Comment:
warning: function 'to_format_string_conservative' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
bool VecDateTimeValue::to_format_string_conservative(const char* format,
size_t len, char* to,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/runtime/vdatetime_value.cpp:686:** 270 lines including
whitespace and comments (threshold 80)
```cpp
bool VecDateTimeValue::to_format_string_conservative(const char* format,
size_t len, char* to,
^
```
</details>
##########
be/src/vec/runtime/vdatetime_value.cpp:
##########
@@ -3449,8 +3452,8 @@
}
template <typename T>
-bool DateV2Value<T>::to_format_string_conservative(const char* format, int
len, char* to,
- int max_valid_length) const
{
+bool DateV2Value<T>::to_format_string_conservative(const char* format, size_t
len, char* to,
Review Comment:
warning: function 'to_format_string_conservative' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
bool DateV2Value<T>::to_format_string_conservative(const char* format,
size_t len, char* to,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/runtime/vdatetime_value.cpp:3454:** 256 lines including
whitespace and comments (threshold 80)
```cpp
bool DateV2Value<T>::to_format_string_conservative(const char* format,
size_t len, char* to,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
